Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261728: SimpleDateFormat should link to DateTimeFormatter #2616

Closed
wants to merge 2 commits into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Feb 17, 2021

Please review this simple doc fix. A CSR will be filed accordingly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261728: SimpleDateFormat should link to DateTimeFormatter

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2616/head:pull/2616
$ git checkout pull/2616

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@naotoj
Copy link
Member Author

@naotoj naotoj commented Feb 17, 2021

/csr

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@naotoj has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@naotoj please create a CSR request and add link to it in JDK-8261728. This pull request cannot be integrated until the CSR request is approved.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

Loading

bplb
bplb approved these changes Feb 17, 2021
Copy link
Member

@bplb bplb left a comment

LGTM

Loading

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Hi Naoto,

Looks good.

Any thoughts to making the new wording stick out more perhaps via a something like "Note: Consider...." and bolding "Note:"

Not sure if it is @APinote worthy but I guess that is an option also?

Loading

@naotoj
Copy link
Member Author

@naotoj naotoj commented Feb 17, 2021

Not sure if it is @APinote worthy but I guess that is an option also?

Good point. Modified.

Loading

bplb
bplb approved these changes Feb 17, 2021
@openjdk openjdk bot removed the csr label Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261728: SimpleDateFormat should link to DateTimeFormatter

Reviewed-by: bpb, rriggs, lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • c158413: 8261098: Add clhsdb "findsym" command
  • 0c31d5b: 8261977: Fix comment for getPrefixed() in canonicalize_md.c
  • 9cf4f90: 8261473: Shenandoah: Add breakpoint support
  • c4664e6: 8261940: Fix references to IOException in BigDecimal javadoc
  • 0e9c5ae: 8075909: [TEST_BUG] The regression-swing case failed as it does not have the 'Open' button when select 'subdir' folder with NimbusLAF
  • e9f3aab: 8261912: Code IfNode::fold_compares_helper more defensively
  • fd098e7: 8261838: Shenandoah: reconsider heap region iterators memory ordering
  • f94a845: 8261600: NMT: Relax memory order for updating MemoryCounter and fix racy updating of peak values
  • 1a7adc8: 8260416: Remove unused method ReferenceProcessor::is_mt_processing_set_up()
  • 3a21e1d: 8260653: Unreachable nodes keep speculative types alive
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/6b6f7940515c623b9e75b20ae536ce5e0ad66030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 19, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Feb 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@naotoj Since your change was applied there have been 51 commits pushed to the master branch:

  • 851b2e3: 6245663: (spec) File.renameTo(File) changes the file-system object, not the File instance
  • c4f17a3: 8257925: enable more support for nested inline tags
  • 433096a: 8261744: Implement CharsetDecoder ASCII and latin-1 fast-paths
  • efbaede: 8262018: Wrong format in SAP copyright header of OsVersionTest
  • 55463b0: 8261984: Shenandoah: Remove unused ShenandoahPushWorkerQueuesScope class
  • a180a38: 8260694: (fc) Clarify FileChannel.transferFrom to better describe "no bytes available" case
  • 1b0c36b: 8261649: AArch64: Optimize LSE atomics in C++ code
  • 61820b7: 8259984: IGV: Crash when drawing control flow before GCM
  • 7e2c909: 8260485: Simplify and unify handler vectors in Posix signal code
  • c99eeb0: 8260858: Implementation specific property xsltcIsStandalone for XSLTC Serializer
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/6b6f7940515c623b9e75b20ae536ce5e0ad66030...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8a1c712.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@naotoj naotoj deleted the JDK-8261728 branch Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants