Skip to content

Conversation

@kboulanou
Copy link
Contributor

@kboulanou kboulanou commented Jul 7, 2025

Fixed an issue where null value component is not checked in class java/awt/Mixing/AWT_Mixing/OverlappingTestBase.

Also removed test java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java from problem list file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #25971 must be integrated first

Warnings

 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/doc-files/JRootPane-1.gif)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/keystore)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/truststore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/dnsstore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/ipstore)

Issue

  • JDK-8361188: Test java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java fails on Mac OS X (Sub-task - P4) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26162/head:pull/26162
$ git checkout pull/26162

Update a local copy of the PR:
$ git checkout pull/26162
$ git pull https://git.openjdk.org/jdk.git pull/26162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26162

View PR using the GUI difftool:
$ git pr show -t 26162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26162.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into pr/25971 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

⚠️ @kboulanou This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@kboulanou The following labels will be automatically applied to this pull request:

  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • javadoc
  • jmx
  • kulla
  • net
  • serviceability
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org kulla kulla-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org javadoc javadoc-dev@openjdk.org jmx jmx-dev@openjdk.org build build-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org net net-dev@openjdk.org labels Jul 7, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

@kboulanou
Copy link
Contributor Author

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@kboulanou
The build label was successfully removed.

@kboulanou
Copy link
Contributor Author

/label remove compiler,core-libs,hotspot,javadoc,jmx,kulla,net,serviceability,shenandoah

@openjdk openjdk bot removed compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org javadoc javadoc-dev@openjdk.org labels Jul 7, 2025
@openjdk openjdk bot removed jmx jmx-dev@openjdk.org kulla kulla-dev@openjdk.org net net-dev@openjdk.org serviceability serviceability-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@kboulanou
The compiler label was successfully removed.

The core-libs label was successfully removed.

The hotspot label was successfully removed.

The javadoc label was successfully removed.

The jmx label was successfully removed.

The kulla label was successfully removed.

The net label was successfully removed.

The serviceability label was successfully removed.

The shenandoah label was successfully removed.

Copy link
Contributor

@alisenchung alisenchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test copyright years, otherwise looks fine

@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@kboulanou this pull request can not be integrated into pr/25971 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jdk-8361188
git fetch https://git.openjdk.org/jdk.git pr/25971
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/25971"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 1, 2025
@kboulanou
Copy link
Contributor Author

This PR fix will be moved to PR #26625 and it will be closed.

@kboulanou kboulanou closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants