-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8361188: Test java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java fails on Mac OS X #26162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
|
|
@kboulanou The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/label remove build |
|
@kboulanou |
|
/label remove compiler,core-libs,hotspot,javadoc,jmx,kulla,net,serviceability,shenandoah |
|
@kboulanou The The The The The The The The |
alisenchung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update test copyright years, otherwise looks fine
|
@kboulanou this pull request can not be integrated into git checkout jdk-8361188
git fetch https://git.openjdk.org/jdk.git pr/25971
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/25971"
git push |
|
This PR fix will be moved to PR #26625 and it will be closed. |
Fixed an issue where null value component is not checked in class java/awt/Mixing/AWT_Mixing/OverlappingTestBase.
Also removed test java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java from problem list file.
Progress
Integration blocker
Warnings
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26162/head:pull/26162$ git checkout pull/26162Update a local copy of the PR:
$ git checkout pull/26162$ git pull https://git.openjdk.org/jdk.git pull/26162/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26162View PR using the GUI difftool:
$ git pr show -t 26162Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26162.diff
Using Webrev
Link to Webrev Comment