8359416: Test 'javax/swing/JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java' failed on Windows 2025 x64 because there is a failure frame while the test case is running#26165
Conversation
|
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
What exactly is the failure thrown in Nimbus L&F? JBS says |
test/jdk/javax/swing/JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java
Outdated
Show resolved
Hide resolved
I ran into the same issue when I previously checked this. I can submit a Nimbus issue afterwards if needed. Wanted to handle the test here first. |
But you are handling the test failure by just omitting Nimbus run, which is not the way to go about it in my opinion.. |
|
ANyways, add the bugid to this PR |
I have gone through the changes again and in converting the test, nothing Nimbus specific was touched. I can't re-run the old test due to its reliance on Applet. When converting the test, I don't believe anyone, including myself, tested it on Nimbus since the test doesn't cycle thru all LAFs. The error in Nimbus only seems to be due to |
That's what I was saying that if it's a Nimbus issue it will not be alright to discard Nimbus testing from the test as it can be a product bug in Nimbus and we can use this regression test to fix that issue, so as a positive side no need to write a new regression test and maybe the bug summary can be changed to show it's failing in Nimbus with "java.lang.RuntimeException: leading cell is not aligned" |
This test only fails in the automated portion on Windows with Nimbus LAF. The failure message is always that the leading cell is not aligned, but I see no obvious issues with the UI when testing myself. The test fails in older JDK versions as well. The original test relies on applet and cannot be run exactly, but this test was previously converted to remove all applet usage in JDK-8354695. Since this test still fails on older JDKs and is not a regression, I chose to skip the test specifically for Nimbus LAF. I suspect this is better than ProblemListing the test for Windows since the test only fails on Windows if Nimbus LAF is used.
I also removed the automated failing of the test to allow the user to see the failure message before the test closes. Test instructions are updated to align with this.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26165/head:pull/26165$ git checkout pull/26165Update a local copy of the PR:
$ git checkout pull/26165$ git pull https://git.openjdk.org/jdk.git pull/26165/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26165View PR using the GUI difftool:
$ git pr show -t 26165Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26165.diff
Using Webrev
Link to Webrev Comment