Skip to content

Conversation

@kboulanou
Copy link
Contributor

@kboulanou kboulanou commented Jul 7, 2025

Changes heavyweight color to white, for the test to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #25971 must be integrated first

Issue

  • JDK-8361192: Test java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java fails on all platforms (Sub-task - P4) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26167/head:pull/26167
$ git checkout pull/26167

Update a local copy of the PR:
$ git checkout pull/26167
$ git pull https://git.openjdk.org/jdk.git pull/26167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26167

View PR using the GUI difftool:
$ git pr show -t 26167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26167.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into pr/25971 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@kboulanou The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

Copy link
Contributor

@alisenchung alisenchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is passing with the change, LGTM

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@kboulanou this pull request can not be integrated into pr/25971 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout jdk-8361192
git fetch https://git.openjdk.org/jdk.git pr/25971
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/25971"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jul 23, 2025
@alisenchung
Copy link
Contributor

Please update copyright years

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jul 24, 2025
@kboulanou
Copy link
Contributor Author

Copyright years updated.

Merge-conflict resolved.

@alisenchung
There are comments in PR #26196 on whether we could merge all dependent fixes in PR #25971.

Please advise if this PR could be merged with #25971

@kboulanou
Copy link
Contributor Author

This PR fix will be moved to PR #26625 and it will be closed.

@kboulanou kboulanou closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants