-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8361599: [PPC64] enable missing tests via jtreg requires #26184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into |
|
@dbriemann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 65 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@dbriemann The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
|
Tests have passed on linux PPC64 Big Endian. |
|
Thanks for testing that! |
|
@dbriemann |
|
/sponsor |
|
Going to push as commit 83feb7a.
Your commit was automatically rebased without conflicts. |
|
@TheRealMDoerr @dbriemann Pushed as commit 83feb7a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport jdk21u-dev |
|
@dbriemann the backport was successfully created on the branch backport-dbriemann-83feb7a2-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev: |
Some tests are not executed on PPC little or big endian because the current requires annotation only checks for "ppc64" or "ppc64le" but not both.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26184/head:pull/26184$ git checkout pull/26184Update a local copy of the PR:
$ git checkout pull/26184$ git pull https://git.openjdk.org/jdk.git pull/26184/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26184View PR using the GUI difftool:
$ git pr show -t 26184Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26184.diff
Using Webrev
Link to Webrev Comment