Skip to content

Conversation

@dbriemann
Copy link
Member

@dbriemann dbriemann commented Jul 8, 2025

Some tests are not executed on PPC little or big endian because the current requires annotation only checks for "ppc64" or "ppc64le" but not both.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361599: [PPC64] enable missing tests via jtreg requires (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26184/head:pull/26184
$ git checkout pull/26184

Update a local copy of the PR:
$ git checkout pull/26184
$ git pull https://git.openjdk.org/jdk.git pull/26184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26184

View PR using the GUI difftool:
$ git pr show -t 26184

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26184.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361599: [PPC64] enable missing tests via jtreg requires

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@dbriemann The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org rfr Pull request is ready for review labels Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 8, 2025
@TheRealMDoerr
Copy link
Contributor

Tests have passed on linux PPC64 Big Endian.

@dbriemann
Copy link
Member Author

Thanks for testing that!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@dbriemann
Your change (at version f79e289) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

Going to push as commit 83feb7a.
Since your change was applied there have been 67 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025
@openjdk openjdk bot closed this Jul 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@TheRealMDoerr @dbriemann Pushed as commit 83feb7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dbriemann dbriemann deleted the dlb/test_requires_ppc_labels branch July 11, 2025 08:21
@dbriemann
Copy link
Member Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

@dbriemann the backport was successfully created on the branch backport-dbriemann-83feb7a2-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 83feb7a2 from the openjdk/jdk repository.

The commit being backported was authored by David Briemann on 9 Jul 2025 and was reviewed by Martin Doerr.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-dbriemann-83feb7a2-master:backport-dbriemann-83feb7a2-master
$ git checkout backport-dbriemann-83feb7a2-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-dbriemann-83feb7a2-master

⚠️ @dbriemann You are not yet a collaborator in my fork openjdk-bots/jdk21u-dev. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants