Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Jul 8, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361175: JFR: Document differences between method sample events (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26202/head:pull/26202
$ git checkout pull/26202

Update a local copy of the PR:
$ git checkout pull/26202
$ git pull https://git.openjdk.org/jdk.git pull/26202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26202

View PR using the GUI difftool:
$ git pr show -t 26202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26202.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361175: JFR: Document differences between method sample events

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the jdk25 branch:

  • 21cb2ac: 8361445: javac crashes on unresolvable constant in @SuppressWarnings
  • 0e4422b: 8361214: An anonymous class is erroneously being classify as an abstract class
  • 1e98516: 8358680: AOT cache creation fails: no strings should have been added

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk25 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 63e08d4af7145b94048d565f4f80dae221090c19 8361175: JFR: Document differences between method sample events Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 8, 2025
@egahlin egahlin marked this pull request as ready for review July 8, 2025 21:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2025
@egahlin
Copy link
Member Author

egahlin commented Jul 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

Going to push as commit 1de8943.
Since your change was applied there have been 4 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2025
@openjdk openjdk bot closed this Jul 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@egahlin Pushed as commit 1de8943.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants