8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

[calvinccheung]

This to to address a review comment for JDK-8202750:
#2581 (comment)

I forgot to push this change before integration for JDK-8202750.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Reviewers

• Yumin Qi (@yminqi - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2621/head:pull/2621
$ git checkout pull/2621

[calvinccheung]

/label delete hotspot
/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung The label delete is not a valid label. These labels are valid:

• serviceability
• hotspot
• sound
• hotspot-compiler
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• 2d
• security
• swing
• hotspot-runtime
• jmx
• build
• nio
• beans
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr
• awt

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[calvinccheung]

/label remove hotspot

[openjdk]

@calvinccheung The hotspot label was not set.

[mlbridge]

Webrevs

• 00: Full (829b906)

[yminqi]

Looks good and is trivial.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Reviewed-by: minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[calvinccheung]

/integrate

[openjdk]

@calvinccheung Pushed as commit b8fd614.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.