Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp #2621

Closed

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Feb 18, 2021

This to to address a review comment for JDK-8202750:
#2581 (comment)

I forgot to push this change before integration for JDK-8202750.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2621/head:pull/2621
$ git checkout pull/2621

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Feb 18, 2021

/label delete hotspot
/label add hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung The label delete is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@openjdk openjdk bot added the hotspot-runtime label Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Feb 18, 2021

/label remove hotspot

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung The hotspot label was not set.

@calvinccheung calvinccheung marked this pull request as ready for review Feb 18, 2021
@openjdk openjdk bot added the rfr label Feb 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

yminqi
yminqi approved these changes Feb 18, 2021
Copy link
Contributor

@yminqi yminqi left a comment

Looks good and is trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261939: os::strdup_check_oom() should be used in os::same_files() in os_windows.cpp

Reviewed-by: minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 18, 2021
@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Feb 18, 2021

/integrate

@openjdk openjdk bot closed this Feb 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 18, 2021
@calvinccheung calvinccheung deleted the 8261939-strdup_check_oom branch Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung Pushed as commit b8fd614.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants