8361102: java.lang.classfile.CodeBuilder.branch(Opcode op, Label target) doesn't throw IllegalArgumentException - if op is not of Opcode.Kind.BRANCH

[liach]

Currently, DirectCodeBuilder is erroneously missing argument checks for a few of its override methods that take arguments such as Opcode and the array size for multianewarray and the switches, which would write something before throwing an exception. We correct these problems and verify with some tests.

Note: Other Label-writing methods resolve their label eagerly so they are not (yet) problematic.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361102: java.lang.classfile.CodeBuilder.branch(Opcode op, Label target) doesn't throw IllegalArgumentException - if op is not of Opcode.Kind.BRANCH (Bug - P3)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26229/head:pull/26229
$ git checkout pull/26229

Update a local copy of the PR:
$ git checkout pull/26229
$ git pull https://git.openjdk.org/jdk.git pull/26229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26229

View PR using the GUI difftool:
$ git pr show -t 26229

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26229.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361102: java.lang.classfile.CodeBuilder.branch(Opcode op,  Label target) doesn't throw IllegalArgumentException - if op is not of Opcode.Kind.BRANCH

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 76442f3: 8361494: [IR Framework] Escape too much in replacement of placeholder
• 445e5ec: 8361342: Shenandoah: Evacuation may assert on invalid mirror object after JDK-8340297
• 3ffc5b9: 8359344: C2: Malformed control flow after intrinsic bailout
• ... and 23 more: https://git.openjdk.org/jdk/compare/6e203384f8777fc55081065b128bd2b0ba074729...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e7716292)

[asotona]

isn this an implicit null check?

[liach]

Yes, but this doesn't run when the list has just one element of null - see case https://github.com/openjdk/jdk/pull/26229/files#diff-cb987200ae23ff7522bd692d4707a012b115bf778a1265ba11db0b3bf5c9aa7cR98

[asotona]

Looks good to me.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 3f59eae.
Since your change was applied there have been 32 commits pushed to the master branch:

• 46988e1: 8361948: Shenandoah: region free capacity unit mismatch
• f7e8d25: 8361905: Problem list serviceability/sa/ClhsdbThreadContext.java on Windows due to JDK-8356704
• 26b0028: 8360776: Disable Intel APX by default and enable it with -XX:+UnlockExperimentalVMOptions -XX:+UseAPX in all builds
• ... and 29 more: https://git.openjdk.org/jdk/compare/6e203384f8777fc55081065b128bd2b0ba074729...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 3f59eae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.