Skip to content

8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays#26234

Closed
dholmes-ora wants to merge 2 commits intoopenjdk:jdk25from
openjdk-bots:backport-dholmes-ora-f67e4354-jdk25
Closed

8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays#26234
dholmes-ora wants to merge 2 commits intoopenjdk:jdk25from
openjdk-bots:backport-dholmes-ora-f67e4354-jdk25

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jul 10, 2025

Hi all,

This pull request contains a backport of commit f67e4354 from the openjdk/jdk repository.

The commit being backported was authored by David Holmes on 10 Jul 2025 and was reviewed by Martin Doerr, Thomas Stuefe and Coleen Phillimore.

There is a follow up fix to the test - JDK-8361754 - that has been incorporated into this PR

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays (Bug - P3)
  • JDK-8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26234/head:pull/26234
$ git checkout pull/26234

Update a local copy of the PR:
$ git checkout pull/26234
$ git pull https://git.openjdk.org/jdk.git pull/26234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26234

View PR using the GUI difftool:
$ git pr show -t 26234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26234.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays
8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f67e4354316dcec185eac66adec2395e20b62579 8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2025

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2025
… cause disk full errors

Reviewed-by: jpai, darcy
@dholmes-ora
Copy link
Member Author

/issue add 8361754

@openjdk openjdk bot removed clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@dholmes-ora
Adding additional issue to issue list: 8361754: New test runtime/jni/checked/TestCharArrayReleasing.java can cause disk full errors.

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense to backport both together.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2025
@dholmes-ora
Copy link
Member Author

Thanks @coleenp !

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

Going to push as commit 9adc480.
Since your change was applied there have been 5 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2025
@openjdk openjdk bot closed this Jul 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@dholmes-ora Pushed as commit 9adc480.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants