8361909: ConstantPoolBuilder::loadableConstantEntry and constantValueEntry should throw NPE

[liach]

Currently, the aforementioned two methods do not throw NPE upon null input, but throw IAE.

This behavior is bad for composition: bsmEntry actually throws IAE for nested null in the argument list/array, and other APIs are similarly affected.

Given this domino effect, I think the best way is to fix the API itself to correctly throw NPE instead. A small CSR is opened to record this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8361910 to be approved

Issues

• JDK-8361909: ConstantPoolBuilder::loadableConstantEntry and constantValueEntry should throw NPE (Bug - P4)
• JDK-8361910: ConstantPoolBuilder::loadableConstantEntry and constantValueEntry should throw NPE (CSR)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26257/head:pull/26257
$ git checkout pull/26257

Update a local copy of the PR:
$ git checkout pull/26257
$ git pull https://git.openjdk.org/jdk.git pull/26257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26257

View PR using the GUI difftool:
$ git pr show -t 26257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26257.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361909: ConstantPoolBuilder::loadableConstantEntry and constantValueEntry should throw NPE

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• a10ee46: 8361224: [macos] MacSignTest.testMultipleCertificates failed
• 6cff49c: 8361380: ARM32: Atomic stubs should be in pre-universe
• ebb1095: 8361492: [IR Framework] Has too restrictive regex for load and store
• ... and 27 more: https://git.openjdk.org/jdk/compare/ee0d309bbd33302d8c6f35155e975db77aaea785...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91f2c6f3)

[asotona]

Looks reasonable.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 0acd065.
Since your change was applied there have been 32 commits pushed to the master branch:

• f36147b: 8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError
• 5cf672e: 8359053: Implement JEP 504 - Remove the Applet API
• a10ee46: 8361224: [macos] MacSignTest.testMultipleCertificates failed
• ... and 29 more: https://git.openjdk.org/jdk/compare/ee0d309bbd33302d8c6f35155e975db77aaea785...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 0acd065.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.