8361950: Update to use jtreg 8

[sormuras]

Please review the change to update to using jtreg 8.

The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various TEST.ROOT files.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361950: Update to use jtreg 8 (Enhancement - P3)

Reviewers

• Iris Clark (@irisclark - Reviewer) Review applies to 7f2017b4
• Joe Wang (@JoeWang-Java - Reviewer) Review applies to bf7b033b
• Jaikiran Pai (@jaikiran - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer) Review applies to bf7b033b
• Magnus Ihse Bursie (@magicus - Reviewer) Review applies to 7f2017b4
• Chen Liang (@liach - Reviewer) Review applies to 7f2017b4
• Alan Bateman (@AlanBateman - Reviewer) Review applies to 7f2017b4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26261/head:pull/26261
$ git checkout pull/26261

Update a local copy of the PR:
$ git checkout pull/26261
$ git pull https://git.openjdk.org/jdk.git pull/26261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26261

View PR using the GUI difftool:
$ git pr show -t 26261

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26261.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361950: Update to use jtreg 8

Reviewed-by: jpai, iris, joehw, erikj, ihse, liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 91a9794: 8367366: Do not support -XX:+AOTClassLinking for dynamic CDS archive
• aa36799: 8367333: C2: Vector math operation intrinsification failure
• 919f5fa: 8367787: Expand use of representation equivalence terminology in Float16
• ... and 23 more: https://git.openjdk.org/jdk/compare/e1071797a4f0ab1a6af29824a777a7800d729b0e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sormuras The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (fd7bf6fd)
• 04: Full - Incremental (7f2017b4)
• 03: Full - Incremental (12b0d0f5)
• 02: Full - Incremental (56006240)
• 01: Full - Incremental (b5112c32)
• 00: Full (bf7b033b)

[JoeWang-Java]

test/jaxp/TEST.ROOT looks good.

[jaikiran]

This looks good to me.

[shqking]

Hi, I encountered two jtreg failures with this new version 8 on both AArch64 and x86_64 platforms.
Note that these two jtreg cases can pass with jtreg 7.5.2+1 version.

some details

JDK source: master
jtreg version: 8+2 version
JDK build: fastdebug
OS: ubuntu 24.04
two jtreg test cases

test/jdk/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java
test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java

how to reproduce:

make test TEST="test/jdk/java/security/SignedJar/spi-calendar-provider/TestSPISigned.java"
make test TEST=test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java

the snippet of error log for case TestSPISigned.java on AArch64

STDERR:                                                                                                                                                                                                                                                      
java.nio.file.NoSuchFileException: /tmp/build-fastdebug/test-support/jtreg_test_jdk_java_security_SignedJar_spi_calendar_provider_TestSPISigned_java/classes/0/java/security/SignedJar/spi-calendar-provider/TestSPISigned.d/../provider/.                   
        at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)                                   
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
        at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:57)
        at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:161)
        at java.base/sun.nio.fs.LinuxFileSystemProvider.readAttributes(LinuxFileSystemProvider.java:99)
        at java.base/java.nio.file.Files.readAttributes(Files.java:1702)
        at java.base/java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:216)                                                                                                                                                                     
        at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:268)   
        at java.base/java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:306)                                                                                                                                                                              
        at java.base/java.nio.file.FileTreeIterator.<init>(FileTreeIterator.java:69)                                          
        at java.base/java.nio.file.Files.find(Files.java:3649)                                                                
        at jdk.test.lib.util.JarUtils.findAllRegularFiles(JarUtils.java:425)                                                                                                                                                                                 
        at jdk.test.lib.util.JarUtils.createJarFile(JarUtils.java:75)                                                         
        at jdk.test.lib.util.JarUtils.createJarFile(JarUtils.java:106)                                                        
        at jdk.test.lib.util.JarUtils.createJarFile(JarUtils.java:115)                                                        
        at TestSPISigned.main(TestSPISigned.java:84)                                                                                                                                                                                                         
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)              
        at java.base/java.lang.reflect.Method.invoke(Method.java:565)                                                         
        at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)                                                                                                                                                            at java.base/java.lang.Thread.run(Thread.java:1474)
                                                                                                                                                                                                                                                             
JavaTest Message: Test threw exception: java.nio.file.NoSuchFileException                                                     
JavaTest Message: shutting down test                 
                                                               
                                                                                                                                                                                                                                                             
TEST RESULT: Failed. Execution failed: `main' threw exception: java.nio.file.NoSuchFileException: /tmp/build-fastdebug/test-support/jtreg_test_jdk_java_security_SignedJar_spi_calendar_provider_TestSPISigned_java/classes/0/java/security/SignedJar/spi-cal
endar-provider/TestSPISigned.d/../provider/.
--------------------------------------------------
Test results: failed: 1   

[jaikiran]

Hello Hao,

Hi, I encountered two jtreg failures with this new version 8 on both AArch64 and x86_64 platforms.
Note that these two jtreg cases can pass with jtreg 7.5.2+1 version.

Thank you for bringing this up. I'm able to reproduce this issue with this newer version of jtreg. I'll take a look to see what's going on.

[shqking]

Hello Hao,

Hi, I encountered two jtreg failures with this new version 8 on both AArch64 and x86_64 platforms.
Note that these two jtreg cases can pass with jtreg 7.5.2+1 version.

Thank you for bringing this up. I'm able to reproduce this issue with this newer version of jtreg. I'll take a look to see what's going on.

Thanks for your confirm, Jaikiran.
Forgot to mention that I tested jdk_all, hotspot_all, langtools_all with jtreg 8 and only found these two test failures.

[sormuras]

Both tests seem to make hard assumptions on where binary files of @library classes are stored.

• TestSPISigned.java#L60-L62
• resexhausted003.java#L83-L96

The storage location changed due to https://bugs.openjdk.org/browse/CODETOOLS-7902847 - it might change again in the near future. Thus, both tests need to be updated to work correctly without relying on a specific location of compiled library classes.

[sormuras]

I updated both tests to be agnostic about the location to where jtreg puts library classes into. See also: https://openjdk.org/jtreg/faq.html#how-do-i-find-the-path-for-the-testng-or-junit-jar-files

[matias9927]

Is there an ETA for integration? There are new tests for Valhalla that are disabled because they rely on some of the new features in JTREG 8. We are working to reinforce testing and are really looking forward to this patch so we can merge it from mainline to lworld.

[sormuras]

Is there an ETA for integration?

On September, 1st.

[AlanBateman]

Is there an ETA for integration?

On September, 1st.

I had a brief discussion with Christian about maybe holding off until the TIMEOUT_FACTOR changes (pull/26749) is integrated.

[liach]

#26749 was merged 4 days ago. Can we integrate this one now?

[AlanBateman]

#26749 was merged 4 days ago. Can we integrate this one now?

I think it would be useful to get input from @dholmes-ora and @lkorinth before doing this. There seems to be several timeout issues in the last few days, a few follow-on changes to adjust the timeout of a few tests, and a spate of tests being reported as timed out after passing. Updating jtreg adds another change to the picture.

[dholmes-ora]

I would appreciate it if this could hold off a while longer as we have a few issues causing noise in our testing at the moment and I don't want to muddy the waters even further. Thanks.

[dholmes-ora]

I'm happy to see this go in now. Thanks

[AlanBateman]

I assume you'll do another run of all tiers before integrating.

[sormuras]

I assume you'll do another run of all tiers before integrating.

Yes. A run of tier 1-8 is in progress, with tier 1-5 already looking very promising.

[jaikiran]

The latest changes in fd7bf6f look good to me.

[sormuras]

/integrate

[openjdk]

Going to push as commit 5db1dfe.
Since your change was applied there have been 32 commits pushed to the master branch:

• a49856b: 8367969: C2: compiler/vectorapi/TestVectorMathLib.java fails without UnlockDiagnosticVMOptions
• 4c7c009: 8367740: assembler_.inline.hpp should not include assembler.inline.hpp
• 04dcaa3: 8367721: Test compiler/arguments/TestCompileTaskTimeout.java crashed: SIGSEGV
• ... and 29 more: https://git.openjdk.org/jdk/compare/e1071797a4f0ab1a6af29824a777a7800d729b0e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras Pushed as commit 5db1dfe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.