-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8362250: ARM32: forward_exception_entry missing return address #26312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8362250: ARM32: forward_exception_entry missing return address #26312
Conversation
|
👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into |
|
@bulasevich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@bulasevich The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right, but I reckon you want to adjust format %{ ... in both match rules as well.
|
Thanks! |
|
Going to push as commit 6ed8164.
Your commit was automatically rebased without conflicts. |
|
@bulasevich Pushed as commit 6ed8164. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk25 |
|
@bulasevich the backport was successfully created on the branch backport-bulasevich-6ed81641-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
The ARM32 ForwardExceptionNode codegen needs to set the exception address to R5. And, since the #20437 change, the TailCall generator does not need this because the StubRoutines::forward_exception_entry function is not called there.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26312/head:pull/26312$ git checkout pull/26312Update a local copy of the PR:
$ git checkout pull/26312$ git pull https://git.openjdk.org/jdk.git pull/26312/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26312View PR using the GUI difftool:
$ git pr show -t 26312Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26312.diff
Using Webrev
Link to Webrev Comment