Skip to content

Conversation

@bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Jul 15, 2025

The ARM32 ForwardExceptionNode codegen needs to set the exception address to R5. And, since the #20437 change, the TailCall generator does not need this because the StubRoutines::forward_exception_entry function is not called there.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362250: ARM32: forward_exception_entry missing return address (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26312/head:pull/26312
$ git checkout pull/26312

Update a local copy of the PR:
$ git checkout pull/26312
$ git pull https://git.openjdk.org/jdk.git pull/26312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26312

View PR using the GUI difftool:
$ git pr show -t 26312

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26312.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362250: ARM32: forward_exception_entry missing return address

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, but I reckon you want to adjust format %{ ... in both match rules as well.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2025
@bulasevich
Copy link
Contributor Author

Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

Going to push as commit 6ed8164.
Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2025
@openjdk openjdk bot closed this Jul 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@bulasevich Pushed as commit 6ed8164.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bulasevich
Copy link
Contributor Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@bulasevich the backport was successfully created on the branch backport-bulasevich-6ed81641-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6ed81641 from the openjdk/jdk repository.

The commit being backported was authored by Boris Ulasevich on 16 Jul 2025 and was reviewed by Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-bulasevich-6ed81641-jdk25:backport-bulasevich-6ed81641-jdk25
$ git checkout backport-bulasevich-6ed81641-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-bulasevich-6ed81641-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants