8362278: G1: Consolidate functions for recording pause start time

[walulyai]

Hi,

Please review this refactoring change to unify the recording of GC Pause start-time.

Testing: Tier 1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362278: G1: Consolidate functions for recording pause start time (Enhancement - P5)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26323/head:pull/26323
$ git checkout pull/26323

Update a local copy of the PR:
$ git checkout pull/26323
$ git pull https://git.openjdk.org/jdk.git pull/26323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26323

View PR using the GUI difftool:
$ git pr show -t 26323

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26323.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362278: G1: Consolidate functions for recording pause start time

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 770d2b4: 8361076: Add benchmark for ImageReader in preparation for Valhalla changes
• 70c1ff7: 8362171: C2 fails with unexpected node in SuperWord truncation: ModI
• 6ed8164: 8362250: ARM32: forward_exception_entry missing return address
• ... and 50 more: https://git.openjdk.org/jdk/compare/99c299f0985c8be63b9b60e589db520d83fd8033...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@walulyai The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (7d3ea11e)
• 01: Full - Incremental (f5ed7d19)
• 00: Full (6094a16c)

[tschatzl]

Could this be named record_pause_start_time() which would better correspond to the record_pause call at the end of the respective pause?

There is also a kind of mismatch to this name and the record_cur_collection_start_sec, which might be more appropriately named record_cur_pause_start_sec following this naming.

It's just right now the code uses gc, collection, pause in the names which makes reading a bit harder than necessary.

[walulyai]

True, in the first commit I had it as record_pause_start_time. Let change both

[walulyai]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit cb9358b.
Since your change was applied there have been 65 commits pushed to the master branch:

• bc9ece9: 8361204: Parallel: Skip visiting per-thread nmethods during young GC
• 1cde536: 8361868: [GCC static analyzer] complains about missing calloc - NULL checks in p11_util.c
• 1a6cbe4: 8361639: JFR: Incorrect top frame for I/O events
• ... and 62 more: https://git.openjdk.org/jdk/compare/99c299f0985c8be63b9b60e589db520d83fd8033...master

Your commit was automatically rebased without conflicts.

[openjdk]

@walulyai Pushed as commit cb9358b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.