Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach #2633

Closed
wants to merge 2 commits into from
Closed

8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach #2633

wants to merge 2 commits into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Feb 18, 2021

The fix also partially fixes JdwpAttachTest failures (JDK-8253940).
The failures are caused by network configuration changes during test execution ("global" IPv6 addresses disappears from interface).
To minimize chances of intermittent failures like this java.net tests use only link-local addresses whenever possible.
The fix does the same for JDI tests (Utils.getAddressesWithSymbolicAndNumericScopes is used by JdwpListenTest and JdwpAttachTest)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2633/head:pull/2633
$ git checkout pull/2633

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@alexmenkov The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime core-libs labels Feb 18, 2021
@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Feb 18, 2021

/label remove core-libs,hotspot-runtime

@openjdk openjdk bot removed core-libs hotspot-runtime labels Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@alexmenkov
The core-libs label was successfully removed.

The hotspot-runtime label was successfully removed.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Feb 18, 2021

/label add serviceability

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Feb 18, 2021

/label add net

@openjdk openjdk bot added the serviceability label Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@alexmenkov
The serviceability label was successfully added.

@openjdk openjdk bot added the net label Feb 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@alexmenkov
The net label was successfully added.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Feb 18, 2021

Added serviceability and net as this is JDI tests, but the issue is networking-related

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Looks good.
Thanks,
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Feb 20, 2021

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8224775: test/jdk/com/sun/jdi/JdwpListenTest.java failed to attach

Reviewed-by: sspitsyn, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 29c7263: 8252709: Enable JVMCI when building linux-aarch64 at Oracle
  • 12f6ba0: 8262087: Use atomic boolean type in G1FullGCAdjustTask
  • a5c4b9a: 8260223: Handling of unnamed package in javadoc pages
  • 8cfea7c: 8261921: ClassListParser::current should be used only by main thread
  • 991f7c1: 8210373: Deadlock in libj2gss.so when loading "j2gss" and "net" libraries in parallel.
  • 0217d69: 8261975: Missing "classpath exception" in VectorSupport.java
  • f2bde05: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229
  • aea474c: 8261269: When using clhsdb to "inspect" a java object, clhsdb prints "Oop for..." twice
  • a7e2e80: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe
  • a30fb4f: 8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/9cf4f90d34fa17c8e9cbe2c4132ff5d7f3d692b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 20, 2021
Copy link
Member

@dfuch dfuch left a comment

I don't see any specific issue with the proposed change but I don't know the JDWP tests enough to provide more feedback than that. Do you have special test cases for the IPv6 loopback? AFAIU this code here will filter it out?

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Feb 22, 2021

I don't see any specific issue with the proposed change but I don't know the JDWP tests enough to provide more feedback than that. Do you have special test cases for the IPv6 loopback? AFAIU this code here will filter it out?

Good catch. IPv6 loopback addresses shouldn't be filtered out.
I'll update PR after re-testing

dfuch
dfuch approved these changes Feb 23, 2021
Copy link
Member

@dfuch dfuch left a comment

The last changes look good to me.

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Mar 4, 2021

/integrate

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@alexmenkov Since your change was applied there have been 167 commits pushed to the master branch:

  • 2848938: 8262927: Explicitly state fields examined for BigDecimal.hashCode
  • b397472: 8262915: java.awt.color.ColorSpace.getName() is not thread-safe
  • 268d9b7: 8261447: MethodInvocationCounters frequently run into overflow
  • 75aa154: 8259267: Refactor LoaderLeak shell test as java test.
  • a118185: 8261862: Expand discussion of rationale for BigDecimal equals/compareTo semantics
  • 2d2ef08: 8262885: Shenandoah: FullGC prologue does not need to save/restore heap has_forwarded_object flag
  • 1d2c1e6: 8248314: Parallel: Parallelize parallel full gc Adjust Roots phase
  • 3d3eb5c: 8262368: wrong verifier message for bogus return type
  • 6d3c858: 8259235: javac crashes while attributing super method invocation
  • bf90e85: 8262926: JDK-8260966 broke AIX build
  • ... and 157 more: https://git.openjdk.java.net/jdk/compare/9cf4f90d34fa17c8e9cbe2c4132ff5d7f3d692b7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 104a262.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the jdwpNoRouteToHost branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net serviceability
3 participants