-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8362271: G1: Improve G1CollectorState::clearing_bitmap name #26330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8362271: G1: Improve G1CollectorState::clearing_bitmap name #26330
Conversation
|
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
|
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
sangheon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
|
Thanks @sangheon for your review |
|
Going to push as commit 27c58c0.
Your commit was automatically rebased without conflicts. |
Hi all,
can I have reviews for this trivial rename of the
clearing_bitmapmember inG1CollectorStateto align it with the other related ones that read<something>_in_progress?Testing: local compilation, gha
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26330/head:pull/26330$ git checkout pull/26330Update a local copy of the PR:
$ git checkout pull/26330$ git pull https://git.openjdk.org/jdk.git pull/26330/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26330View PR using the GUI difftool:
$ git pr show -t 26330Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26330.diff
Using Webrev
Link to Webrev Comment