Skip to content

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 15, 2025

Hi all,

can I have reviews for this trivial rename of the clearing_bitmap member in G1CollectorState to align it with the other related ones that read <something>_in_progress?

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362271: G1: Improve G1CollectorState::clearing_bitmap name (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26330/head:pull/26330
$ git checkout pull/26330

Update a local copy of the PR:
$ git checkout pull/26330
$ git pull https://git.openjdk.org/jdk.git pull/26330/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26330

View PR using the GUI difftool:
$ git pr show -t 26330

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26330.diff

Using Webrev

Link to Webrev Comment

Hi all,

  can I have reviews for this trivial rename of the `clearing_bitmap` member in `G1CollectorState` to align it with the other related ones that read `<something>_in_progress`?

Testing: local compilation, gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362271: G1: Improve G1CollectorState::clearing_bitmap name

Reviewed-by: sangheki

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8362271 8362271: G1: Improve G1CollectorState::clearing_bitmap name Jul 15, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 15, 2025

Webrevs

Copy link
Member

@sangheon sangheon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 15, 2025
@tschatzl
Copy link
Contributor Author

Thanks @sangheon for your review
/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

Going to push as commit 27c58c0.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2025
@openjdk openjdk bot closed this Jul 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

@tschatzl Pushed as commit 27c58c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8362271-clearing-bitmap-rename branch July 16, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants