8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java

[prrace]

Remove a finalize() method in CGraphicsEnvironment, replacing it with Disposer.

I don't see a way to add a test to verify this clean up.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java (Bug - P4)

Reviewers

• Brent Christian (@bchristi-git - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26332/head:pull/26332
$ git checkout pull/26332

Update a local copy of the PR:
$ git checkout pull/26332
$ git pull https://git.openjdk.org/jdk.git pull/26332/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26332

View PR using the GUI difftool:
$ git pr show -t 26332

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26332.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java

Reviewed-by: bchristi, serb, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• a3843e8: 8361751: Test sun/tools/jcmd/TestJcmdSanity.java timed out on Windows
• 60c29ff: 8362524: Fix confusing but harmless typos in x86 CPU Features
• 30d2003: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1
• ... and 56 more: https://git.openjdk.org/jdk/compare/eefbfdce315237eeec4aceceb476d86314304e81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (3a5b6812)
• 02: Full - Incremental (5e9d55ff)
• 01: Full - Incremental (ee8f77a5)
• 00: Full (bc18d382)

[mrserb]

What do you think about moving this "catch Throwable" into Disposer itself? As of now since #9890 we ignore "Exception" only.

[prrace]

I can do that. I can't think of a problem with it.
I should probably then do the same for the other catches of Exception in that file.

I'm a bit on the fence about whether I should

1. keep the print statements there
2. remove them
3. hide them behind a debugging option

I think I'll leave them alone and if we need to we can adjust in another PR.

[bchristi-git]

displayReconfigContext should be final

[prrace]

ok

[prrace]

/integrate

[openjdk]

Going to push as commit 523993e.
Since your change was applied there have been 79 commits pushed to the master branch:

• b8da969: 8362659: Remove sun.print.PrintJob2D.finalize()
• 48ba9d4: 8349946: Cipher javadoc could describe AEAD reuse better
• 9dd93c6: 8361497: Scoped Values: orElse and orElseThrow do not access the cache
• ... and 76 more: https://git.openjdk.org/jdk/compare/eefbfdce315237eeec4aceceb476d86314304e81...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 523993e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.