Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261860: Crash caused by lambda proxy class loaded in Shutdown hook #2634

Closed

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Feb 18, 2021

A simple fix to check if the nest host is in the "linked" state before including its lambda proxy classes in the archive during CDS dynamic dump.

Testing: tier1, hs-tiers 2,3,4.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2634/head:pull/2634
$ git checkout pull/2634

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Feb 18, 2021

/label remove hotspot
/label add hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung The hotspot label was not set.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

Loading

@calvinccheung calvinccheung marked this pull request as ready for review Feb 18, 2021
@openjdk openjdk bot added the rfr label Feb 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

Loading

iklam
iklam approved these changes Feb 19, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Reviewed-by: iklam, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0c31d5b: 8261977: Fix comment for getPrefixed() in canonicalize_md.c
  • 9cf4f90: 8261473: Shenandoah: Add breakpoint support
  • c4664e6: 8261940: Fix references to IOException in BigDecimal javadoc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 19, 2021
yminqi
yminqi approved these changes Feb 19, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

Loading

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Feb 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@calvinccheung Since your change was applied there have been 4 commits pushed to the master branch:

  • c158413: 8261098: Add clhsdb "findsym" command
  • 0c31d5b: 8261977: Fix comment for getPrefixed() in canonicalize_md.c
  • 9cf4f90: 8261473: Shenandoah: Add breakpoint support
  • c4664e6: 8261940: Fix references to IOException in BigDecimal javadoc

Your commit was automatically rebased without conflicts.

Pushed as commit 78cde64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@calvinccheung calvinccheung deleted the 8261860-lambda-proxy-crash branch Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants