Skip to content

8362501: Update test/hotspot/jtreg/applications/jcstress/README#26369

Closed
sendaoYan wants to merge 7 commits intoopenjdk:masterfrom
sendaoYan:jbs8362501
Closed

8362501: Update test/hotspot/jtreg/applications/jcstress/README#26369
sendaoYan wants to merge 7 commits intoopenjdk:masterfrom
sendaoYan:jbs8362501

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 17, 2025

Hi all,

Currently, this is no documentation on how to run the application/jcstress tests. I think it will be useful to complement the document test/hotspot/jtreg/applications/jcstress/README on how to run the jcstress tests in jtreg.

No behaviour has been change, only update the ducumentation, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362501: Update test/hotspot/jtreg/applications/jcstress/README (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26369/head:pull/26369
$ git checkout pull/26369

Update a local copy of the PR:
$ git checkout pull/26369
$ git pull https://git.openjdk.org/jdk.git pull/26369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26369

View PR using the GUI difftool:
$ git pr show -t 26369

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26369.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362501: Update test/hotspot/jtreg/applications/jcstress/README

Reviewed-by: shade, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@sendaoYan
Copy link
Member Author

/cc hotspot-runtime
/cc doc

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 17, 2025
@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jul 17, 2025

@sendaoYan
The label doc is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@mlbridge
Copy link

mlbridge bot commented Jul 17, 2025

Webrevs

@sendaoYan
Copy link
Member Author

Hi @dholmes-ora ,can you review this PR again. The PR has been updated according your suggestions.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical updates look fine - one further one flagged. I can't review as such as I can't validate the instructions being given as I don't know how to run these tests.

Maybe @lmesnik could review?

@dholmes-ora
Copy link
Member

Or @shipilev may be able to review?

Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
@shipilev
Copy link
Member

shipilev commented Jul 25, 2025

Or @shipilev may be able to review?

(slowly turns in his home office chair and stares curiously at his home server that produces jcstress binaries). Meh, I am on the fence on referencing 3rd party personal websites like mine. So I would defer to others if they are good with it.

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 25, 2025

Or @shipilev may be able to review?

(slowly turns in his home office chair and stares curiously at his home server that produces jcstress binaries). Meh, I am on the fence on referencing 3rd party personal websites like mine. So I would defer to others if they are good with it.

The README.md in jcstress repo has already referenced your website~

@sendaoYan
Copy link
Member Author

Or @shipilev may be able to review?

(slowly turns in his home office chair and stares curiously at his home server that produces jcstress binaries). Meh, I am on the fence on referencing 3rd party personal websites like mine. So I would defer to others if they are good with it.

I have removed the 3rd party personal websites.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. I think we can be less specific in the guidance, see below.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 28, 2025
@sendaoYan
Copy link
Member Author

Thanks @shipilev

SendaoYan added 2 commits July 28, 2025 16:27
get the specified build you can reference the guide
@sendaoYan
Copy link
Member Author

Looking for 2rd reviewer.

@sendaoYan
Copy link
Member Author

Thanks for the reviews and suggestions @dholmes-ora @shipilev @lmesnik

/integrate

@openjdk
Copy link

openjdk bot commented Jul 31, 2025

Going to push as commit 559795b.
Since your change was applied there have been 142 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 31, 2025
@openjdk openjdk bot closed this Jul 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 31, 2025
@openjdk
Copy link

openjdk bot commented Jul 31, 2025

@sendaoYan Pushed as commit 559795b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8362501 branch July 31, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants