8362501: Update test/hotspot/jtreg/applications/jcstress/README#26369
8362501: Update test/hotspot/jtreg/applications/jcstress/README#26369sendaoYan wants to merge 7 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 139 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/cc hotspot-runtime |
|
@sendaoYan |
|
@sendaoYan
|
Webrevs
|
|
Hi @dholmes-ora ,can you review this PR again. The PR has been updated according your suggestions. |
dholmes-ora
left a comment
There was a problem hiding this comment.
Grammatical updates look fine - one further one flagged. I can't review as such as I can't validate the instructions being given as I don't know how to run these tests.
Maybe @lmesnik could review?
|
Or @shipilev may be able to review? |
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
(slowly turns in his home office chair and stares curiously at his home server that produces jcstress binaries). Meh, I am on the fence on referencing 3rd party personal websites like mine. So I would defer to others if they are good with it. |
The README.md in jcstress repo has already referenced your website~ |
I have removed the 3rd party personal websites. |
shipilev
left a comment
There was a problem hiding this comment.
Looks better. I think we can be less specific in the guidance, see below.
|
Thanks @shipilev |
get the specified build you can reference the guide
|
Looking for 2rd reviewer. |
|
Thanks for the reviews and suggestions @dholmes-ora @shipilev @lmesnik /integrate |
|
Going to push as commit 559795b.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit 559795b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
Currently, this is no documentation on how to run the application/jcstress tests. I think it will be useful to complement the document test/hotspot/jtreg/applications/jcstress/README on how to run the jcstress tests in jtreg.
No behaviour has been change, only update the ducumentation, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26369/head:pull/26369$ git checkout pull/26369Update a local copy of the PR:
$ git checkout pull/26369$ git pull https://git.openjdk.org/jdk.git pull/26369/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26369View PR using the GUI difftool:
$ git pr show -t 26369Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26369.diff
Using Webrev
Link to Webrev Comment