8362524: Fix confusing but harmless typos in x86 CPU Features

[jankratochvil]

The name DECLARE_CPU_FEATURE_FLAG is used in all other cases. In vmStructs_jvmci.cpp there was no matching #define.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362524: Fix confusing but harmless typos in x86 CPU Features (Bug - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26371/head:pull/26371
$ git checkout pull/26371

Update a local copy of the PR:
$ git checkout pull/26371
$ git pull https://git.openjdk.org/jdk.git pull/26371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26371

View PR using the GUI difftool:
$ git pr show -t 26371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26371.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362524: Fix confusing but harmless typos in x86 CPU Features

Reviewed-by: kbarrett, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 9dc6282: 8362169: Pointer passed to upcall may get wrong scope
• 6949e34: 8362592: Remove unused argument in nmethod::oops_do
• 7da274d: 8361961: Typo in ProtectionDomain.implies
• ... and 6 more: https://git.openjdk.org/jdk/compare/5ed72775a775d6c96be6de7d9540dc0a80cdd67b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@jankratochvil The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (eb8a5261)
• 00: Full (56c13975)

[kimbarrett]

Looks good.

[vnkozlov]

Good.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version eb8a526) is now ready to be sponsored by a Committer.

[vnkozlov]

/sponsor

[openjdk]

Going to push as commit 60c29ff.
Since your change was applied there have been 10 commits pushed to the master branch:

• 30d2003: 8357380: java/lang/StringBuilder/RacingSBThreads.java times out with C1
• 9dc6282: 8362169: Pointer passed to upcall may get wrong scope
• 6949e34: 8362592: Remove unused argument in nmethod::oops_do
• ... and 7 more: https://git.openjdk.org/jdk/compare/5ed72775a775d6c96be6de7d9540dc0a80cdd67b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov @jankratochvil Pushed as commit 60c29ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.