8261998: Remove unused shared entry support from utilities/hashtable

[kimbarrett]

Please review this small cleanup in the utilities/hashtable facility. The
support for "shared" entries is no longer needed or used, so is being deleted.

Testing:
mach5 tier1-4 (some CDS tests are in tier4)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261998: Remove unused shared entry support from utilities/hashtable

Reviewers

• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 4ebdd71
• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to 4ebdd71

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2638/head:pull/2638
$ git checkout pull/2638

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bf811b5)
• 00: Full (4ebdd71)

[coleenp]

We might want to share other hashtables like this, like the loader constraint table, but I don't think this will be needed.

[coleenp]

Nice to get rid of this. It would be nice if the hashtables didn't need to declare bucket() and bucket_addr() with all these casts but some template nonsense makes it not compile.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261998: Remove unused shared entry support from utilities/hashtable

Reviewed-by: coleenp, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

We might want to share other hashtables like this, like the loader constraint table, but I don't think this will be needed.

CDS used to use Hashtable to store stuff into the archive. It doesn't do that anymore, and has switched to CompactHashtable. So the "shared entry" support in Hashtable can be safely deleted.

[kimbarrett]

Thanks @coleenp and @iklam for reviews.

[kimbarrett]

/integrate

[openjdk]

@kimbarrett Pushed as commit 5a25cea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.