Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253291: bug7072653.java still failed "Popup window height ... is wrong" #264

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 19, 2020

Same test as in #197 but this time the intermittent problem appears on the small screen.

The test checks that the size of the popup menu is expected, but the problem is that when we show the popup we calculate it based on some initial insets, but when the windows appeared on the screen its icon is added to the dock, if the dock does not have enough space for the new icons, then all icons in it have become smaller and the height of the dock became smaller as well -> the insets are changed -> the test fails.

BTW for the test purpose, it is recommended to make the dock as small as possible.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253291: bug7072653.java still failed "Popup window height ... is wrong"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/264/head:pull/264
$ git checkout pull/264

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 19, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 19, 2020
@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@mrserb The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Sep 19, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 19, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253291: bug7072653.java still failed "Popup window height ... is wrong"

Reviewed-by: prr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d27835b34e713a80ff6277432f830333d5c4ea17.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 19, 2020
@mrserb
Copy link
Member Author

mrserb commented Sep 19, 2020

/integrate

@openjdk openjdk bot closed this Sep 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2020
@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@mrserb Since your change was applied there have been 3 commits pushed to the master branch:

  • d27835b: 8249142: java/awt/FontClass/CreateFont/DeleteFont.sh is unstable
  • 1438ce0: 8252188: Crash in OrINode::Ideal(PhaseGVN*, bool)+0x8b9
  • 224a30f: 8252311: AArch64: save two words in itable lookup stub

Your commit was automatically rebased without conflicts.

Pushed as commit 83b0537.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253291 branch April 12, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants