-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253291: bug7072653.java still failed "Popup window height ... is wrong" #264
Conversation
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
@mrserb The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 3 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@mrserb Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 83b0537. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Same test as in #197 but this time the intermittent problem appears on the small screen.
The test checks that the size of the popup menu is expected, but the problem is that when we show the popup we calculate it based on some initial insets, but when the windows appeared on the screen its icon is added to the dock, if the dock does not have enough space for the new icons, then all icons in it have become smaller and the height of the dock became smaller as well -> the insets are changed -> the test fails.
BTW for the test purpose, it is recommended to make the dock as small as possible.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/264/head:pull/264
$ git checkout pull/264