-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8362829: Exclude CDS test cases after JDK-8361725 #26400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8362829: Exclude CDS test cases after JDK-8361725 #26400
Conversation
|
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
|
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
calvinccheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial to me.
|
Thanks @calvinccheung for the review. Local testing shows that these two tests are no longer executed with /integrate |
|
Going to push as commit ceb51d4. |
These two test cases uses Java agents. Since JDK-8361725 disallows Java agents with
-XX:+AOTClassLinking, these two tests be excluded from the test grouptest/hotspot/jtreg:hotspot_aot_classlinkingProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26400/head:pull/26400$ git checkout pull/26400Update a local copy of the PR:
$ git checkout pull/26400$ git pull https://git.openjdk.org/jdk.git pull/26400/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26400View PR using the GUI difftool:
$ git pr show -t 26400Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26400.diff
Using Webrev
Link to Webrev Comment