Skip to content

Conversation

@iklam
Copy link
Member

@iklam iklam commented Jul 19, 2025

These two test cases uses Java agents. Since JDK-8361725 disallows Java agents with -XX:+AOTClassLinking, these two tests be excluded from the test group test/hotspot/jtreg:hotspot_aot_classlinking


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362829: Exclude CDS test cases after JDK-8361725 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26400/head:pull/26400
$ git checkout pull/26400

Update a local copy of the PR:
$ git checkout pull/26400
$ git pull https://git.openjdk.org/jdk.git pull/26400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26400

View PR using the GUI difftool:
$ git pr show -t 26400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26400.diff

Using Webrev

Link to Webrev Comment

@iklam iklam marked this pull request as ready for review July 19, 2025 01:52
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2025

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362829: Exclude CDS test cases after JDK-8361725

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2025
@openjdk
Copy link

openjdk bot commented Jul 19, 2025

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 19, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2025

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2025
@iklam
Copy link
Member Author

iklam commented Jul 19, 2025

Thanks @calvinccheung for the review. Local testing shows that these two tests are no longer executed with test/hotspot/jtreg:hotspot_aot_classlinking

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

Going to push as commit ceb51d4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2025
@openjdk openjdk bot closed this Jul 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2025
@openjdk
Copy link

openjdk bot commented Jul 19, 2025

@iklam Pushed as commit ceb51d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants