Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248318: Remove superfluous use of boxing in ObjectStreamClass #2641

Closed
wants to merge 1 commit into from

Conversation

@FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Feb 19, 2021

This change removes some instances of superfluous boxing in java.io.ObjectStreamClass.
Testing: tier 1-3 all clear.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248318: Remove superfluous use of boxing in ObjectStreamClass

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2641/head:pull/2641
$ git checkout pull/2641

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 19, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Feb 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 19, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8248318: Remove superfluous use of boxing in ObjectStreamClass

Reviewed-by: jlaskey, dfuchs, rriggs, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 6b7575b: 8228748: Remove GCLocker::_doing_gc
  • c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
  • 26c1db9: 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.
  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/9cf4f90d34fa17c8e9cbe2c4132ff5d7f3d692b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Feb 19, 2021
Copy link
Contributor

@vyommani vyommani left a comment

Looks ok to me.

Loading

dfuch
dfuch approved these changes Feb 19, 2021
Copy link
Member

@dfuch dfuch left a comment

LGTM. Please add a noreg-cleanup label to the JBS issue.

Loading

Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

LGTM.

Optionally (and trivially), you could update the JIRA description, from "Examine" to "Remove superfluous use of ..." ( or some such )

Loading

@FrauBoes FrauBoes changed the title 8248318: Examine the use of boxing in ObjectStreamClass 8248318: Remove superfluous use of boxing in ObjectStreamClass Feb 22, 2021
@FrauBoes
Copy link
Member Author

@FrauBoes FrauBoes commented Feb 22, 2021

/integrate

Loading

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@FrauBoes Since your change was applied there have been 35 commits pushed to the master branch:

  • 6b7575b: 8228748: Remove GCLocker::_doing_gc
  • c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
  • 26c1db9: 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.
  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/9cf4f90d34fa17c8e9cbe2c4132ff5d7f3d692b7...master

Your commit was automatically rebased without conflicts.

Pushed as commit e9d7c07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@FrauBoes FrauBoes deleted the 8248318 branch Feb 22, 2021
iignatev added a commit to iignatev/jdk that referenced this issue Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment