8261973: Shenandoah: Cleanup/simplify root verifier

[zhengyu123]

Root processing has gone through significant changes. For example, we used to mark through weak roots when class unloading is off, that is no long the case, OopStorages also simplify roots.

Shenandoah root verifier can be simplified into 2 cases, with/without class unloading.

• hotspot_gc_shenandoah with -XX:+ShenandoahVerify

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261973: Shenandoah: Cleanup/simplify root verifier

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2643/head:pull/2643
$ git checkout pull/2643

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ce85e5e)

[rkennke]

Looks good! Thank you!

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261973: Shenandoah: Cleanup/simplify root verifier

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• 63f8fc8: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
• cf0019d: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk
• a6a7e43: 8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions
• d7eebda: 8261391: ZGC crash - SEGV in RevokeOneBias::do_thread
• 5b7b18c: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
• 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
• 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
• e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
• 6b7575b: 8228748: Remove GCLocker::_doing_gc
• c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
• ... and 36 more: https://git.openjdk.java.net/jdk/compare/e9f3aab7f483818944faf8638f421c6960fafbd2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

/integrate

[openjdk]

@zhengyu123 Since your change was applied there have been 46 commits pushed to the master branch:

• 63f8fc8: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
• cf0019d: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk
• a6a7e43: 8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions
• d7eebda: 8261391: ZGC crash - SEGV in RevokeOneBias::do_thread
• 5b7b18c: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
• 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
• 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
• e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
• 6b7575b: 8228748: Remove GCLocker::_doing_gc
• c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
• ... and 36 more: https://git.openjdk.java.net/jdk/compare/e9f3aab7f483818944faf8638f421c6960fafbd2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7b924d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.