8363816: Refactor array name creation

[coleenp]

This is a simple change that refactors the array name creation (using the element class as part of the name), so that it can be called by other classes in valhalla.
Tested with tier1 sanity.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8363816: Refactor array name creation (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Calvin Cheung (@calvinccheung - Reviewer) Review applies to dfbb2155
• David Holmes (@dholmes-ora - Reviewer) Review applies to dfbb2155

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26430/head:pull/26430
$ git checkout pull/26430

Update a local copy of the PR:
$ git checkout pull/26430
$ git pull https://git.openjdk.org/jdk.git pull/26430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26430

View PR using the GUI difftool:
$ git pr show -t 26430

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26430.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363816: Refactor array name creation

Reviewed-by: shade, ccheung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• b02c125: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value
• 06f9ff0: 8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections
• e6ac956: 8360520: RISC-V: C1: Fix primitive array clone intrinsic regression after JDK-8333154
• ... and 48 more: https://git.openjdk.org/jdk/compare/7da274ded4a36c6314702b687fcafcda80ae08c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (bf267900)
• 01: Full - Incremental (dfbb2155)
• 00: Full (c3815d3c)

[shipilev]

This looks like a mechanical move with passing Thread* where needed. Is it? Looks fine if so.

[shipilev]

Seems irrelevant to this PR.

[coleenp]

Yes, this was unintended.

[coleenp]

Yes, it's a mechanical move, and passes JavaThread.

[calvinccheung]

Looks good. Thanks.

[dholmes-ora]

A couple of pre-existing style nits, but as you are here ...

LGTM.

Thanks

[coleenp]

All fixed, thanks for the suggestions that I can click. Can you re-review?

[shipilev]

Something weird is going on with GHA tests, but I believe those are environmental. This is good to go in.

[shipilev]

Speaking of GHA, if you update your https://github.com/coleenp/jdk (it is currently 4400+ commits behind), you'll get some of the nice caching stuff that would likely help these intermittent troubles: https://mail.openjdk.org/pipermail/jdk-dev/2025-July/010211.html

[coleenp]

Thanks for approving Aleksey. I updated my fork just now. Will that help GHA? The problems looked environmental to me but it would be nice to have all passing even for a small change like this.

Thanks for reviewing, Aleksey, David and Calvin.
/integrate

[openjdk]

Going to push as commit 38cd860.
Since your change was applied there have been 52 commits pushed to the master branch:

• 743c821: 8362193: Re-work MacOS/AArch64 SpinPause to handle SB
• b02c125: 8350896: Integer/Long.compress gets wrong type from CompressBitsNode::Value
• 06f9ff0: 8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections
• ... and 49 more: https://git.openjdk.org/jdk/compare/7da274ded4a36c6314702b687fcafcda80ae08c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 38cd860.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.