Skip to content

8363837: Make StubRoutines::crc_table_adr() into platform-specific method #26434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8363837: Make StubRoutines::crc_table_adr() into platform-specific method #26434

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08f2728
8363837: Move StubRoutines::_crc_table_adr initialization to preunive…
vnkozlov Jul 22, 2025
6459712
Fixed Zero VM
vnkozlov Jul 23, 2025
f0378d2
Rework the fix
vnkozlov Jul 23, 2025
71d29f9
Add comment
vnkozlov Jul 24, 2025
eaba165
JVMCI fix
vnkozlov Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/hotspot/share/runtime/stubRoutines.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,9 @@ class StubRoutines: AllStatic {
return dest_uninitialized ? _arrayof_oop_disjoint_arraycopy_uninit : _arrayof_oop_disjoint_arraycopy;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a comment here to note that 1) this method is implemented in architecture-specific code 2) any table that is returned must be allocated once-only in foreign memory rather generated in the code cache.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

// These methods is implemented in architecture-specific code.
// Any table that is returned must be allocated once-only in
// foreign memory (or C heap) rather generated in the code cache.
static address crc_table_addr();
static address crc32c_table_addr();

Expand Down