8361495: (fc) Async close of streams connected to uninterruptible FileChannel doesn't throw AsynchronousCloseException in all cases

[bplb]

Throw AsynchronousCloseException from FileChannelImpl methods if the channel is uninterruptible and was closed before the method (operation) could complete.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361495: (fc) Async close of streams connected to uninterruptible FileChannel doesn't throw AsynchronousCloseException in all cases (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26435/head:pull/26435
$ git checkout pull/26435

Update a local copy of the PR:
$ git checkout pull/26435
$ git pull https://git.openjdk.org/jdk.git pull/26435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26435

View PR using the GUI difftool:
$ git pr show -t 26435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26435.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361495: (fc) Async close of streams connected to uninterruptible FileChannel doesn't throw AsynchronousCloseException in all cases

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• c755345: 8365197: javax.imageio.stream MemoryCache based streams no longer need a disposer.
• c203e70: 8366037: Remove oopDesc::mark_addr()
• 2b44ed7: 8365807: (fs) Two-arg UnixFileAttributes.getIfExists should not use exception for control flow
• ... and 19 more: https://git.openjdk.org/jdk/compare/1a7ac16d239cc1c244955a32baa8f5b32367790d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (1f323f42)
• 04: Full - Incremental (dd4093a1)
• 03: Full - Incremental (a39b2f1b)
• 02: Full - Incremental (899f28cd)
• 01: Full - Incremental (8f708847)
• 00: Full (e6e647f3)

[AlanBateman]

The update to FileChannelImpl looks right.

The change impacts the read methods of input streams obtained from Files.newInputStream and the write methods of output streams obtained from Files.newOutputStream. I'm wonder if we should create a new complete test for this long standing issue. Right now, the test only exercises the available method and I worry that it continues when it runs out of file desciptors.

[bplb]

I'm wonder if we should create a new complete test for this long standing issue.

The test needs some work anyway so I will investigate.

[bplb]

The test as of commit 899f28c passed 100 repeats on Linux and Windows with the change to FileChannelImpl, but failed all 100 repeats on the same platforms without the implementation change.

[bplb]

CI tier 1-3 jobs passed on the usual OSes.

/integrate

[openjdk]

Going to push as commit f1c0b4e.
Since your change was applied there have been 39 commits pushed to the master branch:

• b43c2c6: 8366225: Linux Alpine (fast)debug build fails after JDK-8365909
• 79cea6d: 8365975: Sort share/memory includes
• 1d53ac3: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors
• ... and 36 more: https://git.openjdk.org/jdk/compare/1a7ac16d239cc1c244955a32baa8f5b32367790d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit f1c0b4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.