8258414: OldObjectSample events too expensive #2645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 19, 2021 14:39
|
/label add hotspot-jfr, hotspot |
|
👋 Welcome back fdavid! A progress list of the required criteria for merging this PR into |
openjdk
bot
added
rfr
|
@flodav The |
jbachorik
reviewed
Mar 1, 2021
| @@ -281,6 +281,9 @@ bool JfrRecorder::create_components() { | |||
| if (!create_stacktrace_repository()) { | |||
| return false; | |||
| } | |||
| if (!create_leak_profiler_stacktrace_repository()) { | |||
There was a problem hiding this comment.
Can you add a comment here explaining the purpose of having a separate leak profiler stacktrace repository?
Comment on lines
+26
to
+27
| #include "jfr/leakprofiler/sampling/objectSample.hpp" | ||
| #include "jfr/leakprofiler/sampling/objectSampler.hpp" |
| @@ -197,6 +197,57 @@ static bool stack_trace_precondition(const ObjectSample* sample) { | |||
| return sample->has_stack_trace_id() && !sample->is_dead(); | |||
| } | |||
|
|
|||
| class StackTraceChunkWriter { | |||
There was a problem hiding this comment.
Perhaps, a detailed comment explaining how this is working with the regular stacktrace writer would be good to have here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to reduce the size of JFR recordings when the OldObjectSample event is enabled.
Problem
JFR recordings size blows up when the OldObjectSample is enabled. The memory allocation events are known to be very high traffic and will cause a lot of data, just the sheer number of events produced, and if stacktraces are added to this, the associated metadata can be huge as well. Sampled object are stored in a priority queue and their associated stack traces stored in JFRStackTraceRepository. When sample candidates are removed from the priority queue, their stacktraces remain in the repository, which will be later written at chunk rotation even if the sample has been removed.
Implementation
This PR adds a JFRStackTraceRepository dedicated to store stack traces for the OldObjectSample event. At chunk rotation, every sample stack trace is looked up in this repository and is serialized. Other stack traces are simply removed.
Benchmarks
On an AWS c5.metal instance (96 cores, 192 Gib), running SPECjvm2008 with default profile.jfc configuration with OldObjectSample event enabled gives:
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2645/head:pull/2645$ git checkout pull/2645