Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522. #2646

Closed
wants to merge 1 commit into from

Conversation

vshining
Copy link
Contributor

@vshining vshining commented Feb 19, 2021

This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2646/head:pull/2646
$ git checkout pull/2646

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2021

👋 Welcome back vshining! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 19, 2021
@openjdk
Copy link

openjdk bot commented Feb 19, 2021

@vshining The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 19, 2021
@vshining vshining changed the title 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522 JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522 Feb 19, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2021

Webrevs

@vshining vshining changed the title JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522 JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522. Feb 19, 2021
@iklam
Copy link
Member

iklam commented Feb 19, 2021

Pre-submit test was skipped because:

Testing is not configured
In order to run pre-submit tests, the source repository must be properly configured to allow test execution. See https://wiki.openjdk.java.net/display/SKARA/Testing for more information on how to configure this.

Since this is a build change, please enable pre-submit testing to make sure it doesn't break anything.

@vshining
Copy link
Contributor Author

@iklam Thanks for the notice, the tests have passed now.

@openjdk
Copy link

openjdk bot commented Feb 20, 2021

@vshining This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.

Reviewed-by: iklam, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 390 new commits pushed to the master branch:

  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"
  • 2b00367: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer
  • 5a25cea: 8261998: Remove unused shared entry support from utilities/hashtable
  • 4755958: 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java fails after JDK-8260858
  • b10376b: 8261938: ASN1Formatter.annotate should not return in the finally block
  • 977a21a: 8261225: TieredStopAtLevel should have no effect if TieredCompilation is disabled
  • c53acc2: 8261542: X86 slice and unslice intrinsics for 256-bit byte/short vectors
  • 8b4fd77: 8262042: ProblemList javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java on Windows
  • ... and 380 more: https://git.openjdk.java.net/jdk/compare/06348dfcae0b6b82970e8c56391396affd311f90...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iklam, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2021
@vshining
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2021
@openjdk
Copy link

openjdk bot commented Feb 21, 2021

@vshining
Your change (at version e635cee) is now ready to be sponsored by a Committer.

@kimbarrett
Copy link

/sponsor

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2021
@openjdk
Copy link

openjdk bot commented Feb 22, 2021

@kimbarrett @vshining Since your change was applied there have been 394 commits pushed to the master branch:

  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"
  • 2b00367: 8261350: Create implementation for NSAccessibilityCheckBox protocol peer
  • 5a25cea: 8261998: Remove unused shared entry support from utilities/hashtable
  • 4755958: 8262041: javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java fails after JDK-8260858
  • ... and 384 more: https://git.openjdk.java.net/jdk/compare/06348dfcae0b6b82970e8c56391396affd311f90...master

Your commit was automatically rebased without conflicts.

Pushed as commit 26c1db9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants