-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522. #2646
Conversation
👋 Welcome back vshining! A progress list of the required criteria for merging this PR into |
Pre-submit test was skipped because:
Since this is a build change, please enable pre-submit testing to make sure it doesn't break anything. |
@iklam Thanks for the notice, the tests have passed now. |
@vshining This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 390 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iklam, @kimbarrett) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@kimbarrett @vshining Since your change was applied there have been 394 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 26c1db9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a simple change removing disabling of MSVC++ warning 4522. Since it only affects build process, no tests were ran.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2646/head:pull/2646
$ git checkout pull/2646