8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

[jaikiran]

Can I please get a review of this test-only change which removes the use of Thread.stop() from the test? This addresses https://bugs.openjdk.org/browse/JDK-8360981.

The use of Thread.stop() test/jdk/java/net/Socket/DeadlockTest.java isn't necessary for what this test is currently testing. The commit in this PR removes that call and instead wait for the Thread to complete execution, by calling Thread.join() without any timeouts. If a genuine deadlock does happen, then the test will time out (on the Thread.join() call) and the jtreg infrastructure should then help get hold of the necessary thread dumps to identify the cause of the deadlock.

The test continues to pass with this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26490/head:pull/26490
$ git checkout pull/26490

Update a local copy of the PR:
$ git checkout pull/26490
$ git pull https://git.openjdk.org/jdk.git pull/26490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26490

View PR using the GUI difftool:
$ git pr show -t 26490

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26490.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d37fcca4)

[jaikiran]

Thank you Alan for the review. tier2 tests passed with this change.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 3263361.
Since your change was applied there have been 2 commits pushed to the master branch:

• 8fcbb11: 8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr
• de59da2: 8362581: Timeouts in java/nio/channels/SocketChannel/OpenLeak.java on UNIX

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 3263361.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.