8253311: Cleanup relocInfo constructors

[kimbarrett]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253311: Cleanup relocInfo constructors

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/265/head:pull/265
$ git checkout pull/265

[kimbarrett]

Please review this cleanup of the relocInfo constructors.

We use constructor delegation to avoid code duplication. The old code seems
to have been attempting to fake constructor delegation for similar reasons.

Also fixed some comments about a nonexistent BoundRelocation class.

Testing: mach5 tier1-3

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 00: Full (f5555be)

[vnkozlov]

Looks good.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253311: Cleanup relocInfo constructors

Reviewed-by: kvn, thartmann

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 18 commits pushed to the master branch:

• 43be5a3: 8230652: Improve verbose output
• 5a7390b: 8253418: ZGC: Use pd_ prefix to denote platform dependent code
• 7e49eae: 8253407: Move max_pow2 from test to src
• fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
• dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
• edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
• bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location
• 34ec1be: 8252104: parallel heap inspection for ShenandoahHeap
• fdce055: 8253253: Binutils tar ball extension update to gz
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/22f7af7fcff0d29d741483928d8540ebb6d10379...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 43be5a3cb65d5c8165d9493f56b24c921c40cff3.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Mailing list message from Kim Barrett on hotspot-compiler-dev:

Thanks.

[TobiHartmann]

Looks good.

[mlbridge]

Mailing list message from Kim Barrett on hotspot-compiler-dev:

Thanks.

[kimbarrett]

/integrate

[openjdk]

@kimbarrett Since your change was applied there have been 18 commits pushed to the master branch:

• 43be5a3: 8230652: Improve verbose output
• 5a7390b: 8253418: ZGC: Use pd_ prefix to denote platform dependent code
• 7e49eae: 8253407: Move max_pow2 from test to src
• fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
• dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
• edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
• bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location
• 34ec1be: 8252104: parallel heap inspection for ShenandoahHeap
• fdce055: 8253253: Binutils tar ball extension update to gz
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/22f7af7fcff0d29d741483928d8540ebb6d10379...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2e30ff6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.