8364190: JFR: RemoteRecordingStream withers don't work

[egahlin]

Could I please have a review of a PR that fixes the RemoteRecordingStream::with-methods?

Testing: test/jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364190: JFR: RemoteRecordingStream withers don't work (Bug - P2)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26540/head:pull/26540
$ git checkout pull/26540

Update a local copy of the PR:
$ git checkout pull/26540
$ git pull https://git.openjdk.org/jdk.git pull/26540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26540

View PR using the GUI difftool:
$ git pr show -t 26540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26540.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364190: JFR: RemoteRecordingStream withers don't work

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• ee3665b: 8364187: Make getClassAccessFlagsRaw non-native
• 2ba8a06: 8348868: AArch64: Add backend support for SelectFromTwoVector
• 8ac4a88: 8362237: IllegalArgumentException in the launcher when exception without stack trace is thrown
• ... and 50 more: https://git.openjdk.org/jdk/compare/ea754316fd6d691a701dfb4bc921ea8c92dc5dd4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5b4d40bd)

[dchuyko]

Erik, thanks for the quick fix. Not a reviewer, but looks good (just like expected) and fixes the cases we spotted.

[egahlin]

/integrate

[openjdk]

Going to push as commit da0d959.
Since your change was applied there have been 69 commits pushed to the master branch:

• b96b9c3: 8364461: JFR: Default constructor may not be first in setting control
• 3bc4497: 8364258: ThreadGroup constant pool serialization is not normalized
• cf5a255: 8364427: JFR: Possible resource leak in Recording::getStream
• ... and 66 more: https://git.openjdk.org/jdk/compare/ea754316fd6d691a701dfb4bc921ea8c92dc5dd4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit da0d959.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[egahlin]

/backport jdk25u

[openjdk]

@egahlin the backport was successfully created on the branch backport-egahlin-da0d9598-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit da0d9598 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 4 Aug 2025 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-egahlin-da0d9598-master:backport-egahlin-da0d9598-master
$ git checkout backport-egahlin-da0d9598-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-egahlin-da0d9598-master

⚠️ @egahlin You are not yet a collaborator in my fork openjdk-bots/jdk25u. An invite will be sent out and you need to accept it before you can proceed.