8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages

[jnimeh]

This fix adjusts the SunJSSE provider's handling of the jdk.tls.[client | server].SignatureSchemes property and its effect on messages that assert the signature_algorithms and signature_algorithms_cert extensions, or supported_signature_algorithms vectors like those used in TLS 1.2 CertificateRequest messages. With this change, the ordering of the signature algorithms in the property value will be preserved in the ordering as integer identifiers in the messages itself. Prior to this fix the property algorithms will be asserted, but in the order as shown in the sun.security.ssl.SignatureAlgorithms enumeration.

This does not affect the default ordering of these signature schemes when the property is not given a value.

JBS: https://bugs.openjdk.java.net/browse/JDK-8255867

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2658/head:pull/2658
$ git checkout pull/2658

[bridgekeeper]

👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jnimeh The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (20498ee)
• 01: Full - Incremental (9b9d967)
• 00: Full (4924725)

[XueleiFan]

Looks good to me. Thanks!

[openjdk]

@jnimeh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• a867288: 8211227: Inconsistent TLS protocol version in debug output
• 7b924d8: 8261973: Shenandoah: Cleanup/simplify root verifier
• 63f8fc8: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
• cf0019d: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk
• a6a7e43: 8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions
• d7eebda: 8261391: ZGC crash - SEGV in RevokeOneBias::do_thread
• 5b7b18c: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
• 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
• 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
• e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
• ... and 64 more: https://git.openjdk.java.net/jdk/compare/d547e1a84723e94813fc600c884c9cfee0ed8f57...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jnimeh]

/integrate

[openjdk]

@jnimeh Since your change was applied there have been 74 commits pushed to the master branch:

• a867288: 8211227: Inconsistent TLS protocol version in debug output
• 7b924d8: 8261973: Shenandoah: Cleanup/simplify root verifier
• 63f8fc8: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
• cf0019d: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk
• a6a7e43: 8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions
• d7eebda: 8261391: ZGC crash - SEGV in RevokeOneBias::do_thread
• 5b7b18c: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)
• 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
• 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
• e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
• ... and 64 more: https://git.openjdk.java.net/jdk/compare/d547e1a84723e94813fc600c884c9cfee0ed8f57...master

Your commit was automatically rebased without conflicts.

Pushed as commit a30fb4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.