Skip to content

Conversation

@artur-oracle
Copy link
Member

@artur-oracle artur-oracle commented Jul 31, 2025

Test was broken by JDK-8359956 change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8364484: misc tests fail with Received fatal alert: handshake_failure

Issue

  • JDK-8364484: misc tests fail with Received fatal alert: handshake_failure (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26583/head:pull/26583
$ git checkout pull/26583

Update a local copy of the PR:
$ git checkout pull/26583
$ git pull https://git.openjdk.org/jdk.git pull/26583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26583

View PR using the GUI difftool:
$ git pr show -t 26583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26583.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2025

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2025

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364484: misc tests fail with Received fatal alert: handshake_failure

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8364484 misc tests fail with Received fatal alert: handshake_failure 8364484: misc tests fail with Received fatal alert: handshake_failure Jul 31, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2025
@openjdk
Copy link

openjdk bot commented Jul 31, 2025

@artur-oracle The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jul 31, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2025

Webrevs

Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 31, 2025
@artur-oracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 31, 2025

Going to push as commit 724e8c0.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 31, 2025
@openjdk openjdk bot closed this Jul 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 31, 2025
@openjdk
Copy link

openjdk bot commented Jul 31, 2025

@artur-oracle Pushed as commit 724e8c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Copy link
Contributor

@haimaychao haimaychao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants