8261502: ECDHKeyAgreement: Allows alternate ECPrivateKey impl and revised exception handling #2659
I need a code review of this change to ECDH. It is a combination of fixing the implementation to not only accept ECPrivateKeyImpl along with a fix to the exception handling. They started as two fixes, but with the exception handling the underlying code changed significantly that made the ECPrivateKey change in a different place. The new exception handling is a result of no longer having the native library. Many of the checks waited until generateSecret() to send the keys to the native library. Now that native is gone, checks can happen when keys are provided to the methods and proper exceptions can be thrown instead of wrapping everything as a ProviderException
To checkout this PR locally:
To update a local copy of the PR:
The text was updated successfully, but these errors were encountered:
@ascarpino This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the
@ascarpino Since your change was applied there have been 53 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 374272f.