8364531: G1: Factor out liveness tracing code

[tschatzl]

Hi all,

please review this refactoring, eliminating some copy&paste, in cset candidate group liveness logging.

The output is mostly the same, except for the young cset group, where the "-" has been replaced to just print the default value (0.0) for efficiency. I did not see this important to have, the gc efficiency for young gen isn't interesting.

Testing: local compilation, gha, visual inspection of output

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364531: G1: Factor out liveness tracing code (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Sangheon Kim (@sangheon - Reviewer) Review applies to cb77371d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26591/head:pull/26591
$ git checkout pull/26591

Update a local copy of the PR:
$ git checkout pull/26591
$ git pull https://git.openjdk.org/jdk.git pull/26591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26591

View PR using the GUI difftool:
$ git pr show -t 26591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26591.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364531: G1: Factor out liveness tracing code

Reviewed-by: ayang, sangheki

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• ba0ae4c: 8364254: Serial: Remove soft ref policy update in WhiteBox FullGC
• df736eb: 8364618: Sort share/code includes
• d25b9be: 8325482: Test that distinct seeds produce distinct traces for compiler stress flags
• ... and 41 more: https://git.openjdk.org/jdk/compare/7fbeede14c558221ae0e5b8d65f50e50c0e3737a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (cc413ce7)
• 04: Full - Incremental (6c51c941)
• 03: Full - Incremental (cb77371d)
• 02: Full - Incremental (6f605b70)
• 01: Full - Incremental (d1653627)
• 00: Full (66524c81)

[sangheon]

Hi @sangheon, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user sangheon" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[tschatzl]

Looks good as is.

This might be a preference thing. log_xxx_group() doesn't update _total_remset_bytes while log_xxx_grouplist() updates it. It might be better to update it from log_xxx_group() with or without proper name change? e.g. append_total_and_log_cset_candidate()

I originally considered that then did not do, fixed.

[tschatzl]

Thanks @albertnetymk @sangheon for your reviews

/integrate

[openjdk]

Going to push as commit d906e45.
Since your change was applied there have been 45 commits pushed to the master branch:

• 8a571ee: 8364667: JFR: Throttle doesn't work with dynamic events
• ba0ae4c: 8364254: Serial: Remove soft ref policy update in WhiteBox FullGC
• df736eb: 8364618: Sort share/code includes
• ... and 42 more: https://git.openjdk.org/jdk/compare/7fbeede14c558221ae0e5b8d65f50e50c0e3737a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit d906e45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.