8263552: Use String.valueOf() for char-to-String conversions #2660

stsypanov · 2021-02-20T12:17:32Z

This is a very simple and trivial improvement about getting rid of pointless char wrapping into array

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8263552: Use String.valueOf() for char-to-String conversions

Reviewers

@turbanoff (no known github.com user name / role)
Claes Redestad (@cl4es - Reviewer)
Vyom Tewari (@vyommani - Committer)
Alexander Zvegintsev (@azvegint - Reviewer)
Chris Hegarty (@ChrisHegarty - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2660/head:pull/2660
$ git checkout pull/2660

bridgekeeper · 2021-02-20T12:18:03Z

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-02-20T12:19:10Z

@stsypanov The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

src/java.base/share/classes/java/io/ObjectStreamClass.java

turbanoff · 2021-03-01T12:50:35Z

I think it's worth to cleanup other places with similar code too.
I found 6 places in JDK codebase:

stsypanov · 2021-03-01T14:25:30Z

I think it's worth to cleanup other places with similar code too.

Done

stsypanov · 2021-03-13T14:23:43Z

/issue JDK-8263552

openjdk · 2021-03-13T14:24:05Z

@stsypanov The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

mlbridge · 2021-03-13T14:27:16Z

Webrevs

00: Full (021a4b5)

AlanBateman · 2021-03-13T14:55:53Z

/label add swing

openjdk · 2021-03-13T14:56:13Z

@AlanBateman
The swing label was successfully added.

cl4es

LGTM

src/java.base/share/classes/java/io/ObjectStreamClass.java

openjdk · 2021-03-13T15:19:55Z

⚠️ @stsypanov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout trivial
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

openjdk · 2021-03-13T15:19:56Z

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263552: Use String.valueOf() for char-to-String conversions

Reviewed-by: redestad, vtewari, azvegint, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 287 new commits pushed to the master branch:

fac39fe: 8263508: Remove dead code in MethodHandleImpl
7b4aefe: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
32c7fcc: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
8afec70: 8260931: Implement JEP 382: New macOS Rendering Pipeline
0638303: 8263497: Clean up sun.security.krb5.PrincipalName::toByteArray
ba22e6f: 8263446: Avoid unary minus over unsigned type in ObjectSynchronizer::dec_in_use_list_ceiling
b371f90: 8263504: Some OutputMachOpcodes fields are uninitialized
f7e0a09: 8263425: AArch64: two potential bugs in C1 LIRGenerator::generate_address()
554dd29: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
da9ead5: 8263399: CDS should archive only classes allowed by module system
... and 277 more: https://git.openjdk.java.net/jdk/compare/977a21add8d275dae802a769e6c63675a8ec3ea9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es, @vyommani, @azvegint, @ChrisHegarty) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

stsypanov · 2021-03-13T15:53:39Z

/integrate

openjdk · 2021-03-13T15:53:58Z

@stsypanov
Your change (at version 021a4b5) is now ready to be sponsored by a Committer.

cl4es · 2021-03-14T00:02:25Z

I'll sponsor when I'm back to work on Monday, assuming there are no objections.

vyommani

LGTM

cl4es · 2021-03-15T10:51:08Z

Ok if we change the summary to "Use String.valueOf() for char-to-String conversions"?

stsypanov · 2021-03-15T10:52:06Z

@cl4es done

cl4es · 2021-03-15T11:08:11Z

/sponsor

openjdk · 2021-03-15T11:08:36Z

@cl4es This PR has not yet been marked as ready for integration.

stsypanov · 2021-03-15T11:09:26Z

/integrate

openjdk · 2021-03-15T11:09:41Z

@stsypanov This PR has not yet been marked as ready for integration.

cl4es · 2021-03-15T11:11:21Z

It seems the bots haven't seen that I changed the bug summary to match yet.

stsypanov · 2021-03-15T11:13:54Z

@cl4es could you try /sponsor again? I think this time it should be fine.

cl4es · 2021-03-15T11:18:36Z

/sponsor

openjdk · 2021-03-15T11:19:13Z

@cl4es @stsypanov Since your change was applied there have been 287 commits pushed to the master branch:

fac39fe: 8263508: Remove dead code in MethodHandleImpl
7b4aefe: 8263530: sun.awt.X11.ListHelper.removeAll() should use clear()
32c7fcc: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
8afec70: 8260931: Implement JEP 382: New macOS Rendering Pipeline
0638303: 8263497: Clean up sun.security.krb5.PrincipalName::toByteArray
ba22e6f: 8263446: Avoid unary minus over unsigned type in ObjectSynchronizer::dec_in_use_list_ceiling
b371f90: 8263504: Some OutputMachOpcodes fields are uninitialized
f7e0a09: 8263425: AArch64: two potential bugs in C1 LIRGenerator::generate_address()
554dd29: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
da9ead5: 8263399: CDS should archive only classes allowed by module system
... and 277 more: https://git.openjdk.java.net/jdk/compare/977a21add8d275dae802a769e6c63675a8ec3ea9...master

Your commit was automatically rebased without conflicts.

Pushed as commit c0176c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Use String.valueOf() for char-to-String conversion in ObjectStreamClass

f92773d

openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 20, 2021

c-cleary reviewed Feb 22, 2021

View reviewed changes

src/java.base/share/classes/java/io/ObjectStreamClass.java Show resolved Hide resolved

Fix other occurences

021a4b5

turbanoff approved these changes Mar 1, 2021

View reviewed changes

openjdk bot changed the title ~~Use String.valueOf() for char-to-String conversion in ObjectStreamClass~~ 8263552: Use String.valueOf() for char-to-String conversion in ObjectStreamClass Mar 13, 2021

openjdk bot added the rfr Pull request is ready for review label Mar 13, 2021

openjdk bot added the swing client-libs-dev@openjdk.org label Mar 13, 2021

cl4es approved these changes Mar 13, 2021

View reviewed changes

src/java.base/share/classes/java/io/ObjectStreamClass.java Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 13, 2021

vyommani approved these changes Mar 14, 2021

View reviewed changes

azvegint approved these changes Mar 15, 2021

View reviewed changes

stsypanov changed the title ~~8263552: Use String.valueOf() for char-to-String conversion in ObjectStreamClass~~ 8263552: Use String.valueOf() for char-to-String conversions Mar 15, 2021

openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Mar 15, 2021

ChrisHegarty approved these changes Mar 15, 2021

View reviewed changes

openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Mar 15, 2021

openjdk bot closed this Mar 15, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2021

stsypanov deleted the trivial branch March 15, 2021 11:22

turbanoff mentioned this pull request Nov 22, 2022

[PATCH] Cleanup char/codepoint to String conversion #11064

Closed

3 tasks

8263552: Use String.valueOf() for char-to-String conversions #2660

8263552: Use String.valueOf() for char-to-String conversions #2660

stsypanov commented Feb 20, 2021 •

edited by openjdk bot

bridgekeeper bot commented Feb 20, 2021

openjdk bot commented Feb 20, 2021

turbanoff commented Mar 1, 2021

stsypanov commented Mar 1, 2021

stsypanov commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

mlbridge bot commented Mar 13, 2021

AlanBateman commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

cl4es left a comment

openjdk bot commented Mar 13, 2021

openjdk bot commented Mar 13, 2021 •

edited

stsypanov commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

cl4es commented Mar 14, 2021

vyommani left a comment

cl4es commented Mar 15, 2021

stsypanov commented Mar 15, 2021

cl4es commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

stsypanov commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

cl4es commented Mar 15, 2021

stsypanov commented Mar 15, 2021

cl4es commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

8263552: Use String.valueOf() for char-to-String conversions #2660

8263552: Use String.valueOf() for char-to-String conversions #2660

Conversation

stsypanov commented Feb 20, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Feb 20, 2021

openjdk bot commented Feb 20, 2021

turbanoff commented Mar 1, 2021

stsypanov commented Mar 1, 2021

stsypanov commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

mlbridge bot commented Mar 13, 2021

Webrevs

AlanBateman commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

cl4es left a comment

Choose a reason for hiding this comment

openjdk bot commented Mar 13, 2021

openjdk bot commented Mar 13, 2021 • edited

stsypanov commented Mar 13, 2021

openjdk bot commented Mar 13, 2021

cl4es commented Mar 14, 2021

vyommani left a comment

Choose a reason for hiding this comment

cl4es commented Mar 15, 2021

stsypanov commented Mar 15, 2021

cl4es commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

stsypanov commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

cl4es commented Mar 15, 2021

stsypanov commented Mar 15, 2021

cl4es commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

stsypanov commented Feb 20, 2021 •

edited by openjdk bot

openjdk bot commented Mar 13, 2021 •

edited