Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) #2661

Closed
wants to merge 2 commits into from

Conversation

@DougLea
Copy link
Contributor

@DougLea DougLea commented Feb 20, 2021

This addresses interactions between parallelism-0 and new shutdown support in https://bugs.openjdk.java.net/browse/JDK-8259800


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2661/head:pull/2661
$ git checkout pull/2661

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 20, 2021

👋 Welcome back dl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8259800 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) Feb 20, 2021
@openjdk openjdk bot added the rfr label Feb 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 20, 2021

@DougLea The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Feb 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 20, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2021

@DougLea This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

Reviewed-by: martin, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2021
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Doug,

This looked a little more involved from the version I tested so I re-ran it through the tests - still passed okay :)

Thanks for getting to the bottom of this one - remote debugging is not fun.

Cheers,
David

@DougLea
Copy link
Contributor Author

@DougLea DougLea commented Feb 22, 2021

Thanks David and Martin for the help.

@DougLea
Copy link
Contributor Author

@DougLea DougLea commented Feb 22, 2021

/integrate

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@DougLea Since your change was applied there have been 13 commits pushed to the master branch:

  • 419717d: 8261803: Remove unused TaskTerminator in g1 full gc ref proc executor
  • 011f5a5: 8261799: Remove unnecessary cast in psParallelCompact.hpp
  • e9d7c07: 8248318: Remove superfluous use of boxing in ObjectStreamClass
  • 6b7575b: 8228748: Remove GCLocker::_doing_gc
  • c20fb5d: 8261448: Preserve GC stack watermark across safepoints in StackWalk
  • 26c1db9: 8254239: G1ConcurrentMark.hpp unnecessarily disables MSVC++ warning 4522.
  • 0c21dd0: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method
  • 2b55501: 8261949: fileStream::readln returns incorrect line string
  • 539c80b: 8261702: ClhsdbFindPC can fail due to PointerFinder incorrectly thinking an address is in a .so
  • 564011c: 8261290: Improve error message for NumberFormatException on null input
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/2b00367e1154feb2c05b84a11d62fb5750e46acf...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5b7b18c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DougLea DougLea deleted the JDK-8259800 branch Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants