-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360498: [TEST_BUG] Some Mixing test continue to fail #26625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/25971
Are you sure you want to change the base?
Conversation
|
👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@kboulanou The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try the reporter solution for the failed test ? - JDK-8158801
"We should either use a special separate frame to click on to restore focus handling or hazard to use locationOnScreen"
|
@TejeshR13 I have not tried exactly as was specified in the reported comment. I have tried first to increase the width of the frames, in which case the click will not land on the minimizing control on the frame, and that worked. @prsadhuk then suggested to request focus from the frame, instead of using the workaround click, and that worked too and that is the solution implemented in PR #25971. I will try to center the frames as per suggested. |
|
The tests in this PR require the the fix from #25971 in order for the fix in this PR to work. |
|
As of now, only test java/awt/Mixing/AWT_Mixing/JInternalFrameMoveOverlapping.java and java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java are not yet fixed. |
|
/label remove build |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
/label remove net (typo fix) |
|
@AlanBateman
|
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@AlanBateman |
|
@RogerRiggs |
|
@kboulanou This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keeplive |
|
@kboulanou Unknown command |
This PR will consolidate fixes of the following bugs:
https://bugs.openjdk.org/browse/JDK-8361188
https://bugs.openjdk.org/browse/JDK-8361189
https://bugs.openjdk.org/browse/JDK-8361190
https://bugs.openjdk.org/browse/JDK-8361191
https://bugs.openjdk.org/browse/JDK-8361192
https://bugs.openjdk.org/browse/JDK-8361193
https://bugs.openjdk.org/browse/JDK-8361195
This PR depends on #25971
For test : java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java, the fix suggested is to return false in method isValidForPixelCheck for embedded frame, in which case the component is set to null. For more details see bug: JDK-8361188
For test : test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java, I had to create a a tolerance color matching method for mac for the tests to pass. Also, the jbuttons needed to have different color than the color of the background frame, in order for test to pass. For more detail see bug: https://bugs.openjdk.org/browse/JDK-8361193
For test : test/jdk/java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java, it seems that color selected for lightweight component matches the background color of the frame. And this will cause the test to fail when matching colors. Choosing any color different than the background color will get the test to pass. For more details, see bug: https://bugs.openjdk.org/browse/JDK-8361192
For test test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java, it looks like the frame when visible, the popup test does not work properly. The frame needs to be hidden for the test to click on popup. For more details see bug: https://bugs.openjdk.org/browse/JDK-8361191
For test test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java, the test runs successfully but it times out after the default 2 minutes of jtreg. increasing the timeout to 3 minutes get the test to pass. For more details please refer to bug: https://bugs.openjdk.org/browse/JDK-8361190
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26625/head:pull/26625$ git checkout pull/26625Update a local copy of the PR:
$ git checkout pull/26625$ git pull https://git.openjdk.org/jdk.git pull/26625/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26625View PR using the GUI difftool:
$ git pr show -t 26625Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26625.diff
Using Webrev
Link to Webrev Comment