Skip to content

Conversation

@kboulanou
Copy link
Contributor

@kboulanou kboulanou commented Aug 4, 2025

This PR will consolidate fixes of the following bugs:

https://bugs.openjdk.org/browse/JDK-8361188
https://bugs.openjdk.org/browse/JDK-8361189
https://bugs.openjdk.org/browse/JDK-8361190
https://bugs.openjdk.org/browse/JDK-8361191
https://bugs.openjdk.org/browse/JDK-8361192
https://bugs.openjdk.org/browse/JDK-8361193
https://bugs.openjdk.org/browse/JDK-8361195

This PR depends on #25971

For test : java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java, the fix suggested is to return false in method isValidForPixelCheck for embedded frame, in which case the component is set to null. For more details see bug: JDK-8361188

For test : test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java, I had to create a a tolerance color matching method for mac for the tests to pass. Also, the jbuttons needed to have different color than the color of the background frame, in order for test to pass. For more detail see bug: https://bugs.openjdk.org/browse/JDK-8361193

For test : test/jdk/java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java, it seems that color selected for lightweight component matches the background color of the frame. And this will cause the test to fail when matching colors. Choosing any color different than the background color will get the test to pass. For more details, see bug: https://bugs.openjdk.org/browse/JDK-8361192

For test test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java, it looks like the frame when visible, the popup test does not work properly. The frame needs to be hidden for the test to click on popup. For more details see bug: https://bugs.openjdk.org/browse/JDK-8361191

For test test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java, the test runs successfully but it times out after the default 2 minutes of jtreg. increasing the timeout to 3 minutes get the test to pass. For more details please refer to bug: https://bugs.openjdk.org/browse/JDK-8361190


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #25971 must be integrated first

Issue

  • JDK-8360498: [TEST_BUG] Some Mixing test continue to fail (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26625/head:pull/26625
$ git checkout pull/26625

Update a local copy of the PR:
$ git checkout pull/26625
$ git pull https://git.openjdk.org/jdk.git pull/26625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26625

View PR using the GUI difftool:
$ git pr show -t 26625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26625.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2025

👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into pr/25971 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2025
@openjdk
Copy link

openjdk bot commented Aug 4, 2025

@kboulanou The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Aug 4, 2025

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try the reporter solution for the failed test ? - JDK-8158801
"We should either use a special separate frame to click on to restore focus handling or hazard to use locationOnScreen"

@kboulanou
Copy link
Contributor Author

@TejeshR13 I have not tried exactly as was specified in the reported comment. I have tried first to increase the width of the frames, in which case the click will not land on the minimizing control on the frame, and that worked. @prsadhuk then suggested to request focus from the frame, instead of using the workaround click, and that worked too and that is the solution implemented in PR #25971.

I will try to center the frames as per suggested.

@kboulanou
Copy link
Contributor Author

The tests in this PR require the the fix from #25971 in order for the fix in this PR to work.

@kboulanou
Copy link
Contributor Author

As of now, only test java/awt/Mixing/AWT_Mixing/JInternalFrameMoveOverlapping.java and java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java are not yet fixed.

@AlanBateman
Copy link
Contributor

/label remove build
/label remove compiler
/label remove core-libs
/label remove hotspot
/label remove i18n
/label remove javadoc
/label remove jmx
/label remve net
/label remove nio
/label remove security
/label remove serviceability
/label remove shenandoah

@openjdk openjdk bot removed the build build-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The build label was successfully removed.

@openjdk openjdk bot removed the compiler compiler-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The compiler label was successfully removed.

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The core-libs label was successfully removed.

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The hotspot label was successfully removed.

@openjdk openjdk bot removed the i18n i18n-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The i18n label was successfully removed.

@openjdk openjdk bot removed the javadoc javadoc-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The javadoc label was successfully removed.

@openjdk openjdk bot removed the jmx jmx-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The jmx label was successfully removed.

@RogerRiggs
Copy link
Contributor

/label remove net

(typo fix)

@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The label remve is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@openjdk openjdk bot removed the nio nio-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The nio label was successfully removed.

@openjdk openjdk bot removed the security security-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The security label was successfully removed.

@openjdk openjdk bot removed the serviceability serviceability-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The serviceability label was successfully removed.

@openjdk openjdk bot removed the shenandoah shenandoah-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@AlanBateman
The shenandoah label was successfully removed.

@openjdk openjdk bot removed the net net-dev@openjdk.org label Sep 25, 2025
@openjdk
Copy link

openjdk bot commented Sep 25, 2025

@RogerRiggs
The net label was successfully removed.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

@kboulanou This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@kboulanou
Copy link
Contributor Author

/keeplive

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@kboulanou Unknown command keeplive - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org graal graal-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

5 participants