Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261290: Improve error message for NumberFormatException on null input #2663

Closed
wants to merge 1 commit into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Feb 20, 2021

In Integer and Long, several of the parsing methods are specified to throw NumberFormatException on a null input rather than an NPE. That behavior is not proposed to be modified. However, I think it is reasonable for the NumberFormatException to have a more informative error message than just "null" -- specifically "Cannot parse null string" is proposed here.

All four prior occurrences of

throw new NumberFormatException("null")

have be updated; there were no other instances of this idiom in the java.lang package.

All java/lang/{Integer, Long} regression tests pass with this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261290: Improve error message for NumberFormatException on null input

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2663/head:pull/2663
$ git checkout pull/2663

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 20, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 20, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Feb 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 20, 2021

Webrevs

Copy link
Contributor

@szegedi szegedi left a comment

Rather straightforward 👍

@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261290: Improve error message for NumberFormatException on null input

Reviewed-by: attila, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 21, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Feb 21, 2021

/integrate

@openjdk openjdk bot closed this Feb 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2021

@jddarcy Since your change was applied there have been 3 commits pushed to the master branch:

  • 18188c2: 8261692: Bugs in clhsdb history support
  • 0825bc5: 8261929: ClhsdbFindPC fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • c2509ea: 8261857: serviceability/sa/ClhsdbPrintAll.java failed with "Test ERROR java.lang.RuntimeException: 'cannot be cast to' found in stdout"

Your commit was automatically rebased without conflicts.

Pushed as commit 564011c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8261290 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants