8364280: NMTCommittedVirtualMemoryTracker.test_committed_virtualmemory_region_vm fails with assertion "negative distance"

[afshin-zafari]

The VirtualMemoryTracker API uses a tree internally for tracking the memory regions and their states/info. This tree should not be changed when looking for some regions. If not synch'ed, the nodes in the tree may change meanwhile and the retrieved info are not as expected. The unit test in this PR did not synch these looking up with VMT. The corresponding lock is used to address the problem.

Tests:
local: linux-x64-debug NMTGtests
mach5: tiers 1-5, {macosx-aarch64, linux-x64, windows-x64} x {debug, release}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364280: NMTCommittedVirtualMemoryTracker.test_committed_virtualmemory_region_vm fails with assertion "negative distance" (Bug - P3)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer) Review applies to 829cce44
• Gerard Ziemski (@gerard-ziemski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26689/head:pull/26689
$ git checkout pull/26689

Update a local copy of the PR:
$ git checkout pull/26689
$ git pull https://git.openjdk.org/jdk.git pull/26689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26689

View PR using the GUI difftool:
$ git pr show -t 26689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26689.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364280: NMTCommittedVirtualMemoryTracker.test_committed_virtualmemory_region_vm fails with assertion "negative distance"

Reviewed-by: gziemski, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• bdb1646: 8364611: (process) Child process SIGPIPE signal disposition should be default
• 23985c2: 8357979: Compile jdk.internal.vm.ci targeting the Boot JDK version
• 0ad919c: 8352067: Remove the NMT treap and replace its uses with the utilities red-black tree
• ... and 43 more: https://git.openjdk.org/jdk/compare/0ceb366dc26e2e4f6252da9dd8930b016a5d46ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (43a0a591)
• 00: Full (829cce44)

[gerard-ziemski]

LGTM, thanks for fixing this!

[afshin-zafari]

Thank you @jdksjolen and @gerard-ziemski for your reviews.
/integrate

[openjdk]

Going to push as commit db12f19.
Since your change was applied there have been 53 commits pushed to the master branch:

• d78fa5a: 8365240: [asan] exclude some tests when using asan enabled binaries
• 72d3a2a: 8308349: missing working directory option for launcher when invoked from shortcuts
• 6927fc3: 8365200: RISC-V: compiler/loopopts/superword/TestGeneralizedReductions.java fails with Zvbb and vlen=128
• ... and 50 more: https://git.openjdk.org/jdk/compare/0ceb366dc26e2e4f6252da9dd8930b016a5d46ba...master

Your commit was automatically rebased without conflicts.

[openjdk]

@afshin-zafari Pushed as commit db12f19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.