8365218: [JVMCI] AArch64 CPU features are not computed correctly after 8364128

[mur47x111]

#26515 changes the VM_Version::CPU_ constant values on AArch64 and Graal now sees unsupported CPU features. This may result in SIGILL due to Graal emitting unsupported instructions, such as CPU_SHA3-based eor3 instructions in AArch64 SHA3 stubs.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365218: [JVMCI] AArch64 CPU features are not computed correctly after 8364128 (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26727/head:pull/26727
$ git checkout pull/26727

Update a local copy of the PR:
$ git checkout pull/26727
$ git pull https://git.openjdk.org/jdk.git pull/26727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26727

View PR using the GUI difftool:
$ git pr show -t 26727

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26727.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365218: [JVMCI] AArch64 CPU features are not computed correctly after 8364128

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mur47x111 The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (0056275f)
• 02: Full - Incremental (6aa51798)
• 01: Full - Incremental (3e378957)
• 00: Full (87f4700a)

[dougxc]

LGTM.

[dougxc]

Still good.

[mur47x111]

Thanks for the review!
Passed tier1-3, most of tier9, failures seem unrelated.

/integrate

[openjdk]

Going to push as commit e320162.
Since your change was applied there have been 14 commits pushed to the master branch:

• 3e32985: 8365317: ZGC: Setting ZYoungGCThreads lower than ZOldGCThreads may result in a crash
• a6be228: 8365314: javac fails with an exception for erroneous source
• c22e01d: 8341342: Elements.getAllModuleElements() does not work properly before JavacTask.analyze()
• ... and 11 more: https://git.openjdk.org/jdk/compare/25480f0011297ad209eca1b1b56bcf983ea4ee5d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mur47x111 Pushed as commit e320162.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.