Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Aug 11, 2025

Could I have a review of a change that disables the ModuleExport event in default.jfc? It can use a significant amount of space in some applications, and the event is not that useful. See the bug for details.

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364993: JFR: Disable jdk.ModuleExport in default.jfc (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26728/head:pull/26728
$ git checkout pull/26728

Update a local copy of the PR:
$ git checkout pull/26728
$ git pull https://git.openjdk.org/jdk.git pull/26728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26728

View PR using the GUI difftool:
$ git pr show -t 26728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26728.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364993: JFR: Disable jdk.ModuleExport in default.jfc

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8364993 JFR: Disable jdk.ModuleExport in default.jfc 8364993: JFR: Disable jdk.ModuleExport in default.jfc Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 11, 2025
@egahlin egahlin marked this pull request as ready for review August 11, 2025 18:41
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 11, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 11, 2025
@egahlin
Copy link
Member Author

egahlin commented Aug 12, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

Going to push as commit a382996.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2025
@openjdk openjdk bot closed this Aug 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2025
@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@egahlin Pushed as commit a382996.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants