8365199: Use a set instead of a list as the intermediary Klass* storage to reduce typeset processing

[mgronlun]

Greetings,

This change set is a performance improvement to speed up JFR typeset processing.

It accomplishes this by using a set instead of a list as the intermediary Klass* storage.

Further, the existing JfrSet implementation (currently backed by a linked-list ResizeableResourceHashTable) is optimized to use instead a slimmed open-addressing implementation, premised on the invariant that our sets are key sets.

Running the test program attached to the JIRA issue results in a 100% performance improvement in total running time (by reducing the work set of Klass: es being processed by the JFR Recorder Thread).

Testing: jdk_jfr, stress tests

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365199: Use a set instead of a list as the intermediary Klass* storage to reduce typeset processing (Enhancement - P3)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26733/head:pull/26733
$ git checkout pull/26733

Update a local copy of the PR:
$ git checkout pull/26733
$ git pull https://git.openjdk.org/jdk.git pull/26733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26733

View PR using the GUI difftool:
$ git pr show -t 26733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26733.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365199: Use a set instead of a list as the intermediary Klass* storage to reduce typeset processing

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full (3e337512)
• 05: Full - Incremental (07d9d1ab)
• 04: Full - Incremental (9b9db9f2)
• 03: Full - Incremental (c1707f85)
• 02: Full - Incremental (c9ed816f)
• 01: Full - Incremental (02d6f526)
• 00: Full (dbc9ecd2)

[openjdk]

@mgronlun this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8365199
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @mgronlun This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[egahlin]

Looks good.

[mgronlun]

/integrate

[openjdk]

Going to push as commit 5856dc3.
Since your change was applied there have been 12 commits pushed to the master branch:

• fa2eb61: 8365491: VSCode IDE: add basic configuration for the Oracle Java extension
• e3aeebe: 8365468: EagerJVMCI should only apply to the CompilerBroker JVMCI runtime
• 6fb6f3d: 8361638: java.lang.classfile.CodeBuilder.CatchBuilder should not throw IllegalArgumentException for representable exception handlers
• ... and 9 more: https://git.openjdk.org/jdk/compare/41520998aa8808452ee384b213b2a77c7bad668d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 5856dc3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.