-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine #26742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
@wkia This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @magicus) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
erikj79
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation for this can be found here:
https://mail.openjdk.org/pipermail/build-dev/2017-November/020334.html
Given that we are no longer supporting Solaris in mainline, it should be ok to remove it.
Thank you for digging that out! I was just about to check why in the world we could ever have written something so wonky. I had happily completely forgotten how I wrestled with bad tooling on Solaris. |
magicus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM. Actually, an improvement on all platforms, not only Alpine (sans Solaris...)
|
/integrate |
|
/sponsor |
|
Going to push as commit 4152099.
Your commit was automatically rebased without conflicts. |
This change fixes the test artifact path on Alpine as
'[_*1000]'is not recognized as a correct pattern, at least on Alpine 3.11.Without this fix, on Alpine the command
make test-prebuiltgenerated paths like the following:Now it looks better:
All checks (tier1) are passed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26742/head:pull/26742$ git checkout pull/26742Update a local copy of the PR:
$ git checkout pull/26742$ git pull https://git.openjdk.org/jdk.git pull/26742/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26742View PR using the GUI difftool:
$ git pr show -t 26742Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26742.diff
Using Webrev
Link to Webrev Comment