Skip to content

Conversation

@wkia
Copy link

@wkia wkia commented Aug 12, 2025

This change fixes the test artifact path on Alpine as '[_*1000]' is not recognized as a correct pattern, at least on Alpine 3.11.

Without this fix, on Alpine the command make test-prebuilt generated paths like the following:

Test report is stored in build/run-test-prebuilt/test-results/jtreg]test]hotspot]jtreg]tier1]common

Now it looks better:

Test report is stored in build/run-test-prebuilt/test-results/jtreg_test_hotspot_jtreg_tier1_common

All checks (tier1) are passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26742/head:pull/26742
$ git checkout pull/26742

Update a local copy of the PR:
$ git checkout pull/26742
$ git pull https://git.openjdk.org/jdk.git pull/26742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26742

View PR using the GUI difftool:
$ git pr show -t 26742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26742.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2025

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@wkia The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 12, 2025
@wkia wkia changed the title 8365098: make/RunTests.gmk generates a wrong path on Alpine 8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine Aug 12, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2025

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation for this can be found here:
https://mail.openjdk.org/pipermail/build-dev/2017-November/020334.html

Given that we are no longer supporting Solaris in mainline, it should be ok to remove it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2025
@magicus
Copy link
Member

magicus commented Aug 14, 2025

The explanation for this can be found here:
https://mail.openjdk.org/pipermail/build-dev/2017-November/020334.html

Thank you for digging that out! I was just about to check why in the world we could ever have written something so wonky. I had happily completely forgotten how I wrestled with bad tooling on Solaris.

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Actually, an improvement on all platforms, not only Alpine (sans Solaris...)

@wkia
Copy link
Author

wkia commented Aug 14, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 14, 2025
@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@wkia
Your change (at version 8569ea3) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

magicus commented Aug 14, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

Going to push as commit 4152099.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2025
@openjdk openjdk bot closed this Aug 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 14, 2025
@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@magicus @wkia Pushed as commit 4152099.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the jdk8365098 branch August 14, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants