-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3 #2676
Conversation
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
@fguallini The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one nit.
test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java
Outdated
Show resolved
Hide resolved
@fguallini This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 79 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij, @rhalade) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@fguallini |
/sponsor |
@wangweij @fguallini Since your change was applied there have been 79 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d70fd7b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Kerberos new replay cache format released in 1.18 (installed in OL8.3) is causing the tests failures:
https://web.mit.edu/kerberos/www/krb5-latest/doc/formats/rcache_file_format.html
New and old format are not compatible, that means they cannot share a rcache file. Since there is no interoperability between java GSS-API and native GSS-API new rcache format at the moment, this patch only enables the test scenarios that mimic AP-REQ replays with multiple processes using native GSS-API only (when available) and multiple processes using Java own implementation API only.
If there is a decision to support the new format in the future, tests will be revisited accordingly.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2676/head:pull/2676
$ git checkout pull/2676