Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Aug 13, 2025

The primary goal of JDK-8356447 was to have initialization of the Graal JIT occur in the same phase as the rest of VM startup such that initialization problems are detected and reported prior to executing any user code.

This change caused a performance regression for Truffle when it is used in a JDK that includes both jargraal and libgraal. The problem is that Truffle needs jarjvmci but does not need jargraal when libgraal is available. Initializing jargraal in that configuration delays initialization of Truffle (not just Truffle compilation). Additionally, the jargraal instance created will never be used, wasting memory.

The solution in this PR is to make EagerJVMCI only apply when initializing JVMCI on a CompileBroker thread.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365468: EagerJVMCI should only apply to the CompilerBroker JVMCI runtime (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26768/head:pull/26768
$ git checkout pull/26768

Update a local copy of the PR:
$ git checkout pull/26768
$ git pull https://git.openjdk.org/jdk.git pull/26768/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26768

View PR using the GUI difftool:
$ git pr show -t 26768

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26768.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365468: EagerJVMCI should only apply to the CompilerBroker JVMCI runtime

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Aug 13, 2025
@dougxc dougxc marked this pull request as ready for review August 13, 2025 21:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 14, 2025
@dougxc
Copy link
Member Author

dougxc commented Aug 15, 2025

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

Going to push as commit e3aeebe.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2025
@openjdk openjdk bot closed this Aug 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2025
@openjdk
Copy link

openjdk bot commented Aug 15, 2025

@dougxc Pushed as commit e3aeebe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc
Copy link
Member Author

dougxc commented Aug 18, 2025

/backport jdk25u

@openjdk
Copy link

openjdk bot commented Aug 18, 2025

@dougxc the backport was successfully created on the branch backport-dougxc-e3aeebec-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e3aeebec from the openjdk/jdk repository.

The commit being backported was authored by Doug Simon on 15 Aug 2025 and was reviewed by Tom Rodriguez.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-dougxc-e3aeebec-master:backport-dougxc-e3aeebec-master
$ git checkout backport-dougxc-e3aeebec-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-dougxc-e3aeebec-master

⚠️ @dougxc You are not yet a collaborator in my fork openjdk-bots/jdk25u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants