-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8365468: EagerJVMCI should only apply to the CompilerBroker JVMCI runtime #26768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
|
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Thanks for the review. /integrate |
|
Going to push as commit e3aeebe.
Your commit was automatically rebased without conflicts. |
|
/backport jdk25u |
|
@dougxc the backport was successfully created on the branch backport-dougxc-e3aeebec-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u: |
The primary goal of JDK-8356447 was to have initialization of the Graal JIT occur in the same phase as the rest of VM startup such that initialization problems are detected and reported prior to executing any user code.
This change caused a performance regression for Truffle when it is used in a JDK that includes both jargraal and libgraal. The problem is that Truffle needs jarjvmci but does not need jargraal when libgraal is available. Initializing jargraal in that configuration delays initialization of Truffle (not just Truffle compilation). Additionally, the jargraal instance created will never be used, wasting memory.
The solution in this PR is to make EagerJVMCI only apply when initializing JVMCI on a CompileBroker thread.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26768/head:pull/26768$ git checkout pull/26768Update a local copy of the PR:
$ git checkout pull/26768$ git pull https://git.openjdk.org/jdk.git pull/26768/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26768View PR using the GUI difftool:
$ git pr show -t 26768Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26768.diff
Using Webrev
Link to Webrev Comment