Skip to content

Conversation

@PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Feb 22, 2021

Add missing classpath exception paragraph


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261975: Missing "classpath exception" in VectorSupport.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2678/head:pull/2678
$ git checkout pull/2678

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2021

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2021
@openjdk
Copy link

openjdk bot commented Feb 22, 2021

@PaulSandoz The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 22, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 22, 2021

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261975: Missing "classpath exception" in VectorSupport.java

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a7e2e80: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe
  • a30fb4f: 8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2021
@PaulSandoz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2021
@openjdk
Copy link

openjdk bot commented Feb 23, 2021

@PaulSandoz Since your change was applied there have been 4 commits pushed to the master branch:

  • f2bde05: 8262097: Improve CompilerConfig ergonomics to fix a VM crash after JDK-8261229
  • aea474c: 8261269: When using clhsdb to "inspect" a java object, clhsdb prints "Oop for..." twice
  • a7e2e80: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe
  • a30fb4f: 8255867: SignatureScheme JSSE property does not preserve ordering in handshake messages

Your commit was automatically rebased without conflicts.

Pushed as commit 0217d69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the JDK-8261975-VectorSupport-license-header branch April 26, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants