8364263: HttpClient: Improve encapsulation of ProxyServer #26786
Conversation
| * intended for large numbers of parallel connections. | ||
| */ | ||
| public class ProxyServer extends Thread implements Closeable { | ||
| public final class ProxyServer implements Closeable { |
There was a problem hiding this comment.
Added final to enhance the encapsulation
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
| public ProxyServer(Integer port, | ||
| Boolean debug, | ||
| Credentials credentials) | ||
| private ProxyServer(Integer port, Boolean debug, Credentials credentials) |
There was a problem hiding this comment.
Credentials is a private class, this ctor should not be exposed.
|
@vy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
| public ProxyServer(String s) { | ||
| credentials = null; | ||
| connections = new CopyOnWriteArrayList<Connection>(); | ||
| Thread.ofPlatform().name("ProxyListener").daemon().start(this::run); |
There was a problem hiding this comment.
No need to hold a reference to the Thread. It will terminate either at the JVM exit, or via done flag checked in the run() loop.
| System.out.println("Proxy server listening on port " + ps.getPort()); | ||
| while (true) { | ||
| Thread.sleep(5000); | ||
| try (ProxyServer ps = new ProxyServer(port, debug)) { |
There was a problem hiding this comment.
If we want users to properly wrap ProxyServer in try-with-resources, we should be such an example too.
dfuch
left a comment
dfuch
left a comment
There was a problem hiding this comment.
LGTM. Please make sure to run all tests that might be using this class (tier2 should do it) to double check that none of them use methods from Thread - such as calling proxy.join(). With this change that would no longer compile.
jaikiran
left a comment
jaikiran
left a comment
There was a problem hiding this comment.
Thank you Volkan for cleaning this up. This looks good to me.
|
Going to push as commit 190e113.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
3 participants
Make
ProxyServernot extend fromThread.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26786/head:pull/26786$ git checkout pull/26786Update a local copy of the PR:
$ git checkout pull/26786$ git pull https://git.openjdk.org/jdk.git pull/26786/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26786View PR using the GUI difftool:
$ git pr show -t 26786Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26786.diff
Using Webrev
Link to Webrev Comment