Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails #2679

Closed
wants to merge 3 commits into from

Conversation

@yminqi
Copy link
Contributor

@yminqi yminqi commented Feb 22, 2021

Hi, Please review

When debugging for other test case which uses jcmd to attach LingeredApp process, found there is no error information logged when the app started with function 'startAppExactJvmOpts' exits due to some reason. This is not convenient for trace what is the app failure.
This simple fix for adding finishApp to print out error information when LingeredApp could not start with startAppExactJvmOpts, this is similar to startApp.

Tests: This is a simple fix and done tests with test/jdk/sun/tools/jinfo which uses the function startAppExactJvmOpts to create LingeredApp, also the test case in debugging, which indeed captured the error message upon start error.

Thanks
Yumin


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2679/head:pull/2679
$ git checkout pull/2679

…hen launching fails
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 22, 2021

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@yminqi To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing
@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Feb 23, 2021

/label add hotspot-runtime

@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@yminqi The label test is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt
@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@yminqi
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 23, 2021

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 23, 2021

Mailing list message from David Holmes on hotspot-runtime-dev:

Hi Yumin,

Isn't this a serviceability test utility?

Cheers,
David

On 23/02/2021 11:39 am, Yumin Qi wrote:

@plummercj
Copy link
Contributor

@plummercj plummercj commented Feb 23, 2021

/label serviceability

@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@plummercj
The serviceability label was successfully added.

@iklam
iklam approved these changes Feb 23, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262157: LingeredApp.startAppExactJvmOpts does not print app output when launching fails

Reviewed-by: iklam, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • c769388: 8262266: JDK-8262049 fails validate-source
  • 03e781b: 8262265: ProblemList jdk/javadoc/doclet/testGeneratedClasses/TestGeneratedClasses.java on Windows
  • c6eae06: 8262049: [TESTBUG] Fix TestReferenceRefersTo.java for Shenandoah IU mode
  • e5304b3: 8253409: Double-rounding possibility in float fma
  • 3132b1c: 8261665: Clean up naming of StringContent and FixedStringContent
  • c30a90b: 8261976: Normalize id's used by the standard doclet
  • 53b1545: 8223355: Redundant output by javadoc
  • d2b9c22: 8262011: [JVMCI] allow printing to tty from unattached libgraal thread
  • 0257caa: 8261397: Try Catch Method Failing to Work When Dividing An Integer By 0
  • 8a2f589: 8260637: Shenandoah: assert(_base == Tuple) failure during C2 compilation
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/8a1c712c2ed54fbd3eea14a6ee6fff24e9275812...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 23, 2021
@plummercj
Copy link
Contributor

@plummercj plummercj commented Feb 23, 2021

Looks good. Thanks!

@yminqi
Copy link
Contributor Author

@yminqi yminqi commented Feb 24, 2021

/integrate

@openjdk openjdk bot closed this Feb 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@yminqi Since your change was applied there have been 50 commits pushed to the master branch:

  • c769388: 8262266: JDK-8262049 fails validate-source
  • 03e781b: 8262265: ProblemList jdk/javadoc/doclet/testGeneratedClasses/TestGeneratedClasses.java on Windows
  • c6eae06: 8262049: [TESTBUG] Fix TestReferenceRefersTo.java for Shenandoah IU mode
  • e5304b3: 8253409: Double-rounding possibility in float fma
  • 3132b1c: 8261665: Clean up naming of StringContent and FixedStringContent
  • c30a90b: 8261976: Normalize id's used by the standard doclet
  • 53b1545: 8223355: Redundant output by javadoc
  • d2b9c22: 8262011: [JVMCI] allow printing to tty from unattached libgraal thread
  • 0257caa: 8261397: Try Catch Method Failing to Work When Dividing An Integer By 0
  • 8a2f589: 8260637: Shenandoah: assert(_base == Tuple) failure during C2 compilation
  • ... and 40 more: https://git.openjdk.java.net/jdk/compare/8a1c712c2ed54fbd3eea14a6ee6fff24e9275812...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3e13b66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yminqi yminqi deleted the yminqi:jdk-8262157 branch Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants